Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <8923010.6471274389758027.JavaMail.jira@thor>
Date: Thu, 20 May 2010 17:09:18 -0400 (EDT)
From: "Jay D. McHugh (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-4130) Unable to preserve comments from
 plan.xml into config.xml
In-Reply-To: <1438461023.1213820264915.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GERONIMO-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869772#action_12869772 ] 

Jay D. McHugh commented on GERONIMO-4130:
-----------------------------------------

This ticket has two parts.  The original issue was enabling and disabling services.  The issue of comments came up because that used to be the way to accomplish enabling and disabling services.

I think that the issue of enabling and disabling services is already handled by the 'load' attribute of the 'module' entities.  If I am mistaken about using the load attribute to control whether a particular module starts or not then this ticket is valid.  And we need to make sure that there is a simple and straight forward way to determine which modules are started (we also need to make sure that the title of this ticket is changed to reflect the actual problem).

If the load attribute does control which modules actually start, then the use of comments in the config.xml file is a completely separate issue.  And, it should get it's own (new) ticket.

Here is a discussion of how comments are being handled in the config.xml and why.  If anyone thinks that it would be worthwhile to handle 'true XML comments' then we should open a new ticket to track that.

There is a problem with using 'real' comments.  And that problem is that the tools that are being used to parse the XML files completely ignore them.

So, whenever one of these files are parsed and then recreated - the comment would be lost.  That is why the <comment> tag was used in the first place.  Comments are normally 'for human consumption' only.  We needed to put them into the actual XML data in order to tell the parser that they really are a part of the data and not just fluff for people to read.

The config.xml file is read in during server start up and recreated from scratch during shutdown.  Real XML style comments (and their location within the file) do not appear to be maintained by the parser/builder.  We would need to make our own XML parser that internally converted the comments into XML data and a new XML builder that would re-convert that special comment data back into actual comments.

Sorry that it took so long for me to realize that I was answering a different problem than the real issue.  

Lin,

Have I finally seen the problem that you were trying to bring up (modifying which services start)?

Do you still think that there is a problem with how comments are being handled?

Jay

> Unable to preserve comments from plan.xml into config.xml
> ---------------------------------------------------------
>
>                 Key: GERONIMO-4130
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4130
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: car-maven-plugin
>    Affects Versions: 2.1.x, 2.2
>            Reporter: Lin Sun
>             Fix For: 2.2.1, Wish List
>
>
> I got a user asking me how to turn off tomcat access log.
> It was easy in previous releases, as we could provide comment in config.xml and tell the users to "To disable accesslogging uncomment the following section...".   However, with our new config.xml, we don't preserve any comments, which makes hard for users to config things.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.