Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 5640 invoked from network); 27 May 2010 10:22:13 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 27 May 2010 10:22:13 -0000 Received: (qmail 52797 invoked by uid 500); 27 May 2010 10:22:09 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 52662 invoked by uid 500); 27 May 2010 10:22:09 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 51046 invoked by uid 99); 27 May 2010 10:22:06 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 May 2010 10:22:06 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 May 2010 10:22:03 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4RALgsE022534 for ; Thu, 27 May 2010 10:21:42 GMT Message-ID: <10420906.19151274955702646.JavaMail.jira@thor> Date: Thu, 27 May 2010 06:21:42 -0400 (EDT) From: "Rick McGuire (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Updated: (GERONIMO-4907) GBeanInstance to Ignore Missing Setters In-Reply-To: <111151243.1255594591665.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMO-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rick McGuire updated GERONIMO-4907: ----------------------------------- Fix Version/s: 3.0-M1 (was: 2.2) (was: 3.0) > GBeanInstance to Ignore Missing Setters > --------------------------------------- > > Key: GERONIMO-4907 > URL: https://issues.apache.org/jira/browse/GERONIMO-4907 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: kernel > Affects Versions: 2.1.4, 2.1.5, 2.2, 3.0 > Reporter: Quintin Beukes > Assignee: David Jencks > Fix For: 3.0-M1 > > Attachments: ignore-missing-accessors.patch > > > Related to GERONIMO-4903 > I submitted a patch which fixes the problem by removing the attributes which don't have setters. > After reading the OpenEJB source I noticed an XBean feature which would be a more correct fix for the problem. > Instead of removing the attributes which won't have setters in the class being instantiated as a GBean, configure the ObjectRecipe to rather ignore those properties which don't have setters. This has 2 benefits > 1) Those properties can still be included for "read" access > 2) If such a property exists for any other GBean, or is added in the future, this will help that those don't possibly create fatal bugs - which the JettyConnector bug almost was (you couldn't edit a connector - ever). > This is achieved by adding the following line after the ObjectRecipe was created: > objectRecipe.allow(Option.IGNORE_MISSING_PROPERTIES); > This permissions merely removes the property from the list of properties to "create the object with", if the accessor wasn't found. > Since those properties are still available, they can be accessed by the GBean API, and thus it doesn't become a requirement to have setter accessors for all persistent properties. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.