geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rick McGuire <rick...@gmail.com>
Subject Re: Trunk snapshot dependencies
Date Tue, 11 May 2010 00:25:42 GMT
On 5/10/2010 6:35 PM, David Blevins wrote:
> On May 10, 2010, at 3:24 AM, Rick McGuire wrote:
>
>    
>> On 5/7/2010 8:41 PM, David Blevins wrote:
>>      
>>> On May 4, 2010, at 9:58 AM, Rick McGuire wrote:
>>>
>>>
>>>        
>>>> 2)  Xbean.  Has a dependency on the Aries code.  Should be ready for a vote
as soon as the Aries
>>>> vote closes.
>>>>
>>>>          
>>> Created that copy of OpenEJB.  It also depends on XBean.  So add one more to
the "blocked" list.
>>>
>>> -David
>>>
>>>
>>>
>>>        
>> David,
>>
>> I'm getting a test failure in openejb-core when I try to build this version, but
I'm not sure I understand what's going wrong.  Here's the failure information, but from the
data displayed here, it looks like this should be passing?  Could this possibly be a Windows
vs. unix linend problem?
>>      
> Likely, though svn should be giving both files the same line endings.  This file should
have appropriate line endings for your system:
>
>    container/openejb-core/src/test/resources/convert/oej2/simple/openejb-jar-expected.xml
>    
The file appears to have crlf endings like I would expect.  I 
uncommented the couple of lines in the test case that dumped the 
expected and actual strings, and this is what I got:

expected = "<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<openejb-jar xmlns="http://www.openejb.org/openejb-jar/1.1">
     <properties>module.property.b=valueb
module.property.a=valuea
</properties>
     <ejb-deployment ejb-name="FooBean" deployment-id="FooBean">
         <jndi interface="Local" name="thename"/>
         <jndi interface="Remote" name="anothername"/>
         <jndi interface="LocalHome" name="loldstyle"/>
         <jndi interface="RemoteHome" name="roldstyle"/>
         <properties>bean.property.b=valueb
bean.property.a=valuea
</properties>
     </ejb-deployment>
</openejb-jar>"
actual = "<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<openejb-jar xmlns="http://www.openejb.org/openejb-jar/1.1">
     <properties>module.property.b=valueb&#xD;
module.property.a=valuea&#xD;
</properties>
     <ejb-deployment ejb-name="FooBean" deployment-id="FooBean">
         <jndi interface="Local" name="thename"/>
         <jndi interface="Remote" name="anothername"/>
         <jndi interface="LocalHome" name="loldstyle"/>
         <jndi interface="RemoteHome" name="roldstyle"/>
         <properties>bean.property.b=valueb&#xD;
bean.property.a=valuea&#xD;
</properties>
     </ejb-deployment>
</openejb-jar>"

I'm guessing the problem is caused by the &#xD; entities at the line 
break positions, but I'm not sure where those are getting generated.  
Nor am I certain if the problem is caused because those are generated or 
the Diff class is not processing them correctly.

Rick
> -David
>
>
>    
>> -------------------------------------------------------------------------------
>> Test set: org.apache.openejb.config.OpenEjb2ConversionTest
>> -------------------------------------------------------------------------------
>> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.563 sec<<<
  FAILURE!
>> testSimple(org.apache.openejb.config.OpenEjb2ConversionTest)  Time elapsed: 1.062
sec<<<   FAILURE!
>> junit.framework.AssertionFailedError: Files are similar org.custommonkey.xmlunit.Diff
>> [different] Expected text value 'module.property.b=valueb
>> module.property.a=valuea
>> ' but was 'module.property.b=valueb
>> module.property.a=valuea
>> ' - comparing<properties ...>module.property.b=valueb
>> module.property.a=valuea
>> </properties>   at /openejb-jar[1]/properties[1]/text()[1] to<properties
...>module.property.b=valueb
>> module.property.a=valuea
>> </properties>   at /openejb-jar[1]/properties[1]/text()[1]
>>
>>         at junit.framework.Assert.fail(Assert.java:47)
>>         at junit.framework.Assert.assertTrue(Assert.java:20)
>>         at org.apache.openejb.config.OpenEjb2ConversionTest.assertJaxb(OpenEjb2ConversionTest.java:110)
>>         at org.apache.openejb.config.OpenEjb2ConversionTest.testSimple(OpenEjb2ConversionTest.java:50)
>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>         at java.lang.reflect.Method.invoke(Method.java:597)
>>         at junit.framework.TestCase.runTest(TestCase.java:168)
>>         at junit.framework.TestCase.runBare(TestCase.java:134)
>>         at junit.framework.TestResult$1.protect(TestResult.java:110)
>>         at junit.framework.TestResult.runProtected(TestResult.java:128)
>>         at junit.framework.TestResult.run(TestResult.java:113)
>>         at junit.framework.TestCase.run(TestCase.java:124)
>>         at junit.framework.TestSuite.runTest(TestSuite.java:232)
>>         at junit.framework.TestSuite.run(TestSuite.java:227)
>>         at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79)
>>         at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
>>         at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
>>         at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:165)
>>         at org.apache.maven.surefire.Surefire.run(Surefire.java:107)
>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>>         at java.lang.reflect.Method.invoke(Method.java:597)
>>         at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:289)
>>         at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:993)
>>
>>
>>
>>      
>
>    


Mime
View raw message