geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bohn <joe.b...@earthlink.net>
Subject Re: [VOTE] Release Geronimo Customized Tomcat
Date Fri, 30 Apr 2010 19:10:37 GMT

IIUC then I think we do need to fix this for the following reasons:

1) We are releasing these artifacts - even if they are copies of Tomcat 
artifacts.  The artifact is being released under the groupID 
"org.apache.geronimo.ext.tomcat" and it is being released in source (not 
just binary) form.

2) In addition to that, I can't see where Tomcat has actually ever 
released these files - so it may be that we are "pre-releasing" them 
rather than "re-releasing" them.  I see a tag for Tomcat 7.0.0 RC1 but I 
don't see any artifacts available yet on any repositories.

Joe


On 4/30/10 2:29 PM, Donald Woods wrote:
> Since those are Tomcat source files, does that really mean we have to
> fix their source before we can re-release it?
>
>
> -Donald
>
>
> On 4/30/10 1:10 PM, Joe Bohn wrote:
>>
>> -1 (sorry)
>>
>> There are some files with invalid license headers:
>> /util/src/main/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java
>>
>> /util/src/main/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java
>>
>>
>>
>> Joe
>>
>>
>> On 4/28/10 6:30 AM, Ivan wrote:
>>> Please vote for Geronimo Customized Tomcat 7.0.0.0
>>>
>>>    Vote will be open for 72 hours.
>>>
>>>    [ ] +1  approve
>>>    [ ] +0  no opinion
>>>    [ ] -1  disapprove (and reason why)
>>>
>>>
>>> Staging repo:
>>>
>>> https://repository.apache.org/content/repositories/orgapachegeronimo-030/
>>> <https://repository.apache.org/content/repositories/orgapachegeronimo-027/>
>>>
>>>
>>> Source repo:
>>>
>>> https://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-7.0.0.0/
>>>
>>>
>>> --
>>>
>>> I have run the servlet TCK, at least, it does not bring new failures.
>>>
>>> I paste svn log to show the Tomcat revision :
>>> ------------------------------------------------------------------------
>>> r938833 | xuhaihong | 2010-04-28 17:13:40 +0800 (Wed, 28 Apr 2010) | 1
>>> line
>>>
>>> [maven-release-plugin] prepare for next development iteration
>>> ------------------------------------------------------------------------
>>> r938831 | xuhaihong | 2010-04-28 17:12:51 +0800 (Wed, 28 Apr 2010) | 1
>>> line
>>>
>>> [maven-release-plugin] prepare release tomcat-parent-7.0.0.0
>>> ------------------------------------------------------------------------
>>> r938824 | xuhaihong | 2010-04-28 17:00:58 +0800 (Wed, 28 Apr 2010) | 1
>>> line
>>>
>>> Merge Tomcat r938814 to fix the ArrayIndexOutOfBoundsException
>>> ------------------------------------------------------------------------
>>> r938801 | xuhaihong | 2010-04-28 14:52:22 +0800 (Wed, 28 Apr 2010) | 1
>>> line
>>>
>>> Revert the changes due to key verification error
>>> ------------------------------------------------------------------------
>>> r938794 | xuhaihong | 2010-04-28 14:11:44 +0800 (Wed, 28 Apr 2010) | 1
>>> line
>>>
>>> [maven-release-plugin] prepare for next development iteration
>>> ------------------------------------------------------------------------
>>> r938792 | xuhaihong | 2010-04-28 14:11:19 +0800 (Wed, 28 Apr 2010) | 1
>>> line
>>>
>>> [maven-release-plugin] prepare release tomcat-parent-7.0.0.0
>>> ------------------------------------------------------------------------
>>> r938790 | xuhaihong | 2010-04-28 14:01:21 +0800 (Wed, 28 Apr 2010) | 1
>>> line
>>>
>>> Fix an ArrayIndexOutOfBoundsException exception
>>> ------------------------------------------------------------------------
>>> r938375 | xuhaihong | 2010-04-27 17:33:06 +0800 (Tue, 27 Apr 2010) | 1
>>> line
>>>
>>> Merge r938373 from Tomcat trunk
>>> ------------------------------------------------------------------------
>>> r938331 | xuhaihong | 2010-04-27 14:52:17 +0800 (Tue, 27 Apr 2010) | 1
>>> line
>>>
>>> Not sure why those configurations are missed while copying them from
>>> tomcat-archetype...
>>> ------------------------------------------------------------------------
>>> r938306 | xuhaihong | 2010-04-27 11:14:03 +0800 (Tue, 27 Apr 2010) | 1
>>> line
>>>
>>> Use the released spec versions
>>> ------------------------------------------------------------------------
>>> r938303 | xuhaihong | 2010-04-27 10:53:48 +0800 (Tue, 27 Apr 2010) | 1
>>> line
>>>
>>> GERONIMO-4980 new tomcat snapshot at rev 938302
>>>
>>>
>>> Thanks
>>> Ivan
>>
>>
>


Mime
View raw message