geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Jain (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-5027) Redeploy option for farming
Date Tue, 09 Mar 2010 12:10:27 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-5027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843022#action_12843022
] 

Ashish Jain commented on GERONIMO-5027:
---------------------------------------

Hi Shawn,

Thanks for all your comments and improvements.

I have fixed 1). I am not sure how 2) works because I do not see any app or plan which you
are trying to redeploy. 

The results above indicate the patch you upload need to rework. I also found two obvious possible
problems in the patch:

1, if(args.length>=3 && args[0].equalsIgnoreCase("--targets")) //case of cluster
redeployment
+ {

The lines above hard coded the --targets as the first args, If the user put the --targets
in different sequence, the command will fail.

"""""I am not sure if user can specify --targets in any order because I see ""commandLine
= parser.parse(options, args, true); in DistributeCommandArgsImpl gives different results
if u specify 
--target in any order.""""""""

Thanks
Ashish


I am still looking into it

> Redeploy option for farming
> ---------------------------
>
>                 Key: GERONIMO-5027
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5027
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>    Affects Versions: 2.1.4, 2.2
>         Environment: Windows XP g214
>            Reporter: Ashish Jain
>            Assignee: Ashish Jain
>             Fix For: 2.1.5, 2.2.1
>
>         Attachments: 5027_21.patch
>
>
> Redeploy feature for farming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message