geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick McGuire (JIRA)" <>
Subject [jira] Commented: (GERONIMO-5178) Inconsistent handling of META-INF/services files by different Geronmo specs.
Date Wed, 10 Mar 2010 17:15:36 GMT


Rick McGuire commented on GERONIMO-5178:

Ok, will do.  I don''t believe I'm introducing anything that will be a problem here.  I'm
not changing the lookup order at all, just delegating the reading/parsing of the META-INF/services
files to methods I'm adding to the ProviderLocator class that is already getting included
in the bundle as a result of my prior updates.   I've avoided using the ServiceLoader class
for some of this stuff for precisely that reason. 

> Inconsistent handling of META-INF/services files by different Geronmo specs. 
> -----------------------------------------------------------------------------
>                 Key: GERONIMO-5178
>                 URL:
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 3.0
>            Reporter: Rick McGuire
>            Assignee: Rick McGuire
>             Fix For: 3.0
> A number of the Geronimo specs use the provider resolution pattern defined by the ServiceLoader
class in Java 6 to resolve different provider classes.  In this pattern, a file with a given
class name in the META-INF/services directory can define one or more provider classes for
a given source interface name.  As implemented by the ServiceLoader class, these files can
contain multiple lines with pure comment lines and line comments on lines that define classes,
as well as multiple providers defined per file.  Thus a file like this would be considered
> # A set of provider classes for the blah.blah interface
>  # The default first one 
>  # The secondary fall back. 
> The different spec projects that use these files parse them under different assumptions:
> - Some unilaterally take the first line without any comment processing at all or recognition
that there might be multiple providers defined per file. 
> - Some projects allow for pure comment lines but don't parse for comments on a definition
> - Not all projects are opening these files assuming a utf-8 encoding. 
> This could best be solved by refactoring the code to use some common methods.  This refactoring
will also allow OSGi-awareness to be added to the service file lookups.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message