geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashish Jain (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-5172) ImageDownload.java bug in writing to buffer in 'Accessing JDBC in Web applications' tutorial page
Date Sat, 06 Mar 2010 07:07:27 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842211#action_12842211
] 

Ashish Jain commented on GERONIMO-5172:
---------------------------------------

You seem to be correct. Do you see an abnormal behavior with the existing code??

> ImageDownload.java bug in writing to buffer in 'Accessing JDBC in Web applications' tutorial
page
> -------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-5172
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5172
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: documentation
>    Affects Versions: 2.2
>         Environment: N/A
>            Reporter: Scott Oberg
>            Priority: Trivial
>
> The 'Accessing JDBC in Web applications' page in the tutorial contains a bug in the ImageDownload.java
sample code.
> http://cwiki.apache.org/GMOxDOC22/accessing-jdbc-in-web-applications.html
> The line 'out.write(b);' should be replaced with 'out.write(b, 0, c);' and a check to
make sure there is data to read.
> {noformat} 
> original code:
> while (c != -1) {
>   c = ip.read(b);
>   out.write(b);
>   out.flush();
> }
> fix:
> while (c != -1) {
>   c = ip.read(b);
>   if (c > 0) {
>     out.write(b, 0, c);
>     out.flush();
>   }
> }
> {noformat} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message