geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lu Jiang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMODEVTOOLS-283) Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context root
Date Thu, 25 Feb 2010 07:54:27 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838230#action_12838230
] 

Lu Jiang commented on GERONIMODEVTOOLS-283:
-------------------------------------------

Use latest GEP build,I faild to rename the name of  Dynamic Web Project from "hello" to "hi".

I created a simple helloworld project,and name this project as "hello",then a default geronimo-web.xml
is created.

 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
<web:web-app xmlns:app="http://geronimo.apache.org/xml/ns/j2ee/application-2.0" xmlns:client="http://geronimo.apache.org/xml/ns/j2ee/application-client-2.0"
xmlns:conn="http://geronimo.apache.org/xml/ns/j2ee/connector-1.2" xmlns:dep="http://geronimo.apache.org/xml/ns/deployment-1.2"
xmlns:ejb="http://openejb.apache.org/xml/ns/openejb-jar-2.2" xmlns:log="http://geronimo.apache.org/xml/ns/loginconfig-2.0"
xmlns:name="http://geronimo.apache.org/xml/ns/naming-1.2" xmlns:pers="http://java.sun.com/xml/ns/persistence"
xmlns:pkgen="http://openejb.apache.org/xml/ns/pkgen-2.1" xmlns:sec="http://geronimo.apache.org/xml/ns/security-2.0"
xmlns:web="http://geronimo.apache.org/xml/ns/j2ee/web-2.0.1">
    <dep:environment>
        <dep:moduleId>
            <dep:groupId>default</dep:groupId>
            <dep:artifactId>hello</dep:artifactId>
            <dep:version>1.0</dep:version>
            <dep:type>car</dep:type>
        </dep:moduleId>
    </dep:environment>
    <web:context-root>/hello</web:context-root>
</web:web-app>

Click Refactor->Rename to change the project name from "hello" to "hi".
The check box shown in the screen snapshot didn't appear.So I  cann't  choose whether to "rename
artifact-id and context-root in geronimo-web.xml".
But actually ,some wrong operation was done to artifactId and moduleId in geronimo-web.xml
during Renaming.
See the geronimo-web.xml below,after rename from "hello" to "hi",it became a badly formed
xml file.
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<web:web-app xmlns:app="http://geronimo.apache.org/xml/ns/j2ee/application-2.0" xmlns:client="http://geronimo.apache.org/xml/ns/j2ee/application-client-2.0"
xmlns:conn="http://geronimo.apache.org/xml/ns/j2ee/connector-1.2" xmlns:dep="http://geronimo.apache.org/xml/ns/deployment-1.2"
xmlns:ejb="http://openejb.apache.org/xml/ns/openejb-jar-2.2" xmlns:log="http://geronimo.apache.org/xml/ns/loginconfig-2.0"
xmlns:name="http://geronimo.apache.org/xml/ns/naming-1.2" xmlns:pers="http://java.sun.com/xml/ns/persistence"
xmlns:pkgen="http://openejb.apache.org/xml/ns/pkgen-2.1" xmlns:sec="http://geronimo.apache.org/xml/ns/security-2.0"
xmlns:web="http://geronimo.apache.org/xml/ns/j2ee/web-2.0.1">
    <dep:environment>
        <dep:moduleId>
            <dep:groupId>default</dep:groupId>
            <dep:artifactId>hehidep:artifactId>
            <dep:version>1.0</dep:version>
            <dep:type>car</dep:type>
        </dep:moduleId>
    </dep:environment>
    <web:context-root>/h/hiweb:context-root>
</web:web-app>

I suggest to reopen this JIRA.


> Refactoring a Dynamic Web Project's name doesn't refactor it's artifact id & context
root
> -----------------------------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-283
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-283
>             Project: Geronimo-Devtools
>          Issue Type: Wish
>          Components: eclipse-plugin
>            Reporter: Shiva Kumar H R
>            Priority: Minor
>             Fix For: 2.1.5, 2.2.0
>
>         Attachments: extend_rename.patch, screenshot-1.jpg, screenshot-2.jpg
>
>
> When a Dynamic Web Project with name say "tt" is created, a Geronimo deployment plan
"geronimo-web.xml" will get created with module-id as "default/tt-1.0.car" and context-root
as "/tt". 
> When this project is re-factored to say "tz", the module-id will still be the same "default/tt-1.0.car"
(note that artifact id is not re-factored from "tt" to "tz"). The context-root also remains
the same "/tt". 
> Although this doesn't pose any problem, wouldn't it be better to refactor the artifact-id
& context-root to match the project name?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message