geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Delos Dai (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMODEVTOOLS-599) Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1, testsuite fixes
Date Mon, 11 Jan 2010 06:02:00 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798580#action_12798580
] 

Delos Dai commented on GERONIMODEVTOOLS-599:
--------------------------------------------

Hi Johannes,

Thanks for your patch! 

The last two items in your description seems OK for me. I will commit the patch.
But I'm not clear about your fix for first item. It only add x86 arch,but it will failed on
OS which returns x86_64. Are you sure you're using a x86_64 OS?

For the building problem on 64 bit system, I think the root cause is the detecting mechanism.
Currently, in build.xml, we make use of architecture detecting in maven activation. In fact,
it's based on the value of System.getProperty("os.arch"). The issue is that the value returned
by this method is not predictable. Take Linux  for example, different Linux kernel or JDK
may returns different values for the same architecture. More details, you can refer to http://lopica.sourceforge.net/os.html.

Besides the issue above, I think we made a mistake to detect the OS architecture. The right
thing we have to detect is the data model(32bit or 64bit) of JDK, instead of the OS architecture,
because a 32-bit JDK can also be used in a 64-bit OS. Therefor, I searched another property
to get the data model of JDK. Now, the property I found is "sun.arch.data.model". The value
System.getProperty("sun.arch.data.model") is 32 for 32-bit JDK or 64 for 64-bit JDK. Although
it's not a standard property in JDK API doc, I have tried it with both 5.0 and 6.0 JDK. 

To resolve the issue of JDK data model, I think we have to make use of property "sun.arch.data.model".
I have created GERONIMODEVTOOLS-600 to track the improvement based on property "sun.arch.data.model".








> Compilation on x86_64 systems, simplifications of the build.xml files, Eclipse 3.5.1,
testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-599
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.2.0
>         Environment: linux x86_64
>            Reporter: Johannes Weberhofer
>            Assignee: Tim McConnell
>         Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have fixed the pom.xml
file again and replaced i386 architecture by x86; hope, this works on your build environments,
too.
> * simplified the build.xml files by replacing the "galileo" parameters by a more general
"eclipse" parameter, which makes changes between eclipse releases much easier (changes have
to be done in the header sections only). At the same time I have upgraded to galileo version
3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to depend on
the common target. The testsuite runs much better now on x86_64 (but still produces an error)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message