Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 34702 invoked from network); 3 Dec 2009 15:17:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Dec 2009 15:17:54 -0000 Received: (qmail 76464 invoked by uid 500); 3 Dec 2009 15:17:54 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 76373 invoked by uid 500); 3 Dec 2009 15:17:53 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 76365 invoked by uid 99); 3 Dec 2009 15:17:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2009 15:17:53 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jgawor@gmail.com designates 209.85.218.218 as permitted sender) Received: from [209.85.218.218] (HELO mail-bw0-f218.google.com) (209.85.218.218) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2009 15:17:51 +0000 Received: by bwz10 with SMTP id 10so1181005bwz.35 for ; Thu, 03 Dec 2009 07:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=EgxAbnO8Bi5fCFdITBJcIq/Xp4XZnAsJ4q+OuxU/NV8=; b=XiDDzKEfIik0QXjZwmPf4jr+PJCCj6FBxqZe/RkWBKk+b8mTRs12WkC3yC14UsqJc+ lI3fdil02gOZ3L1dOK0P2/+NUJB4XMdq4rOuumo+gdjUKu5GXAJh9aUO/1v6GFasdqXt cpreiG3UCO7KDTSkX1kc4VQ6e5Ui7xpkRoGZo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=pmclpGkUKXYXV6lYGZ4G+ysbWGUiJtE6fnQu/1XyFumZpii17MlP280YO/N9yVqrH4 X4pf/n+cZ726AKIwH1dWi4r/cw9U1VCsme7t61pqgzVif8PEeD87bKjxZ5RSAyoHIbhM 73e1r+cdCl8pF5Aam4uBXWbUexJcZHyfM2gwg= MIME-Version: 1.0 Received: by 10.204.34.73 with SMTP id k9mr1829758bkd.45.1259853450111; Thu, 03 Dec 2009 07:17:30 -0800 (PST) In-Reply-To: <45f744e40912030119p76263a3es73236cb9dfb7e002@mail.gmail.com> References: <45f744e40912012053l42fb08b3t4fffecff72dfe41d@mail.gmail.com> <1FF30AC2-EF64-4A7C-84AA-F6772096A572@yahoo.com> <45f744e40912022122q66eb6cf7w3affb4376e51c718@mail.gmail.com> <45f744e40912030024s22c2f40dl5cac3c203047b86f@mail.gmail.com> <1C1A9487-284F-402E-8B02-D8EF04BF38EA@yahoo.com> <45f744e40912030119p76263a3es73236cb9dfb7e002@mail.gmail.com> Date: Thu, 3 Dec 2009 10:17:29 -0500 Message-ID: <5eb405c70912030717n551f51ebk140467fa1ff9c38@mail.gmail.com> Subject: Re: How to define those bundlized dependencies which would be published by Geronimo From: Jarek Gawor To: dev@geronimo.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Yes. That's my experience with optional setting too. Jarek On Thu, Dec 3, 2009 at 4:19 AM, Ivan wrote: > Not sure whether I missed anything, From my understanding, it has nothing= to > do with car-maven-plugin. While the optional is configurred with true, ma= ven > would not add it as its dependency, and it has the same effect of marking > the original jar as an exclusion in the pom file of the project depending= on > the bundle. > > 2009/12/3 David Jencks >> >> On Dec 3, 2009, at 12:24 AM, Ivan wrote: >> >> I remembered that while the configuration true is >> added, it should not cause the transitive dependency of the original jar >> file. Will re-validate it later ...... >> >> That is not my experience. =A0At least, our geronimo dependency manageme= nt >> doesn't see it that way. =A0Maybe this is a bug in the car-maven-plugin. >> thanks >> david jencks >> >> 2009/12/3 David Jencks >>> >>> On Dec 2, 2009, at 9:22 PM, Ivan wrote: >>> >>> >>> 2009/12/2 David Jencks >>>> >>>> On Dec 2, 2009, at 1:01 AM, David Jencks wrote: >>>> >>>>> I have no problem with the idea of including dependencies on bundleiz= ed >>>>> versions of the original dependencies, this seems to me like a good >>>>> convention. >>>>> >>>>> However I don't see any use in the exclusions =A0you show, since the >>>>> original non-bundleized jar is a dependency of the new bundle, and ne= eds to >>>>> be excluded whenever we use it. =A0Excluding the original jar will al= so >>>>> exclude all of its dependencies, so the exclusions you show won't hav= e any >>>>> effect. >>>>> >>>>> I think we need to work hard to push the bundleization back into the >>>>> originating project and to modify the felix bundle plugin so the orig= inal >>>>> non-bundle doesn't end up as a transitive dependency of the bundle. >>>> >>>> I think I found a way to avoid the transitive dependencies problem usi= ng >>>> . =A0Here's a bit of the jstl bundleization pom: >>>> >>>> =A0 =A0 >>>> =A0 =A0 =A0 =A0 >>>> =A0 =A0 =A0 =A0 =A0 =A0${pkgGroupId} >>>> =A0 =A0 =A0 =A0 =A0 =A0${pkgArtifactId} >>>> =A0 =A0 =A0 =A0 =A0 =A0${pkgVersion} >>>> =A0 =A0 =A0 =A0 =A0 =A0provided >>>> =A0 =A0 =A0 =A0 >>>> =A0 =A0 >>>> >>>> =A0 =A0 >>>> =A0 =A0 =A0 =A0 >>>> =A0 =A0 =A0 =A0 =A0 =A0 >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0org.apache.felix >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0maven-bundle-plugin >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>> >>>> =A0*;scope=3Dprovided;inline=3Dtrue >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>> =A0 =A0 =A0 =A0 =A0 =A0 >>>> =A0 =A0 =A0 =A0 >>>> =A0 =A0 >>>> >>>> I have some moderately extensive changes pending so I'd appreciate it = if >>>> anyone interested in adopting this approach wait a day or so before >>>> committing it. >>> >>> =A0 Could you please explain it more ? From the generated manifest.mf f= ile >>> and the dependency tree, I did not find any different. Thanks ! >>> >>> The files included in the bundle should be exactly the same. =A0However= , >>> since the dependency in the pom is marked "provided", it is not a maven >>> transitive dependency of the bundle. =A0Therefore the original jar does= not >>> need to be excluded from the bundle when you use the bundle as a maven >>> dependency in a project. >>> hope this is clearer :-) >>> thanks >>> david jencks >>> >>> >>>> >>>> thanks >>>> david jencks >>>> >>>> >>>>> >>>>> thanks >>>>> david jencks >>>>> >>>>> On Dec 1, 2009, at 8:53 PM, Ivan wrote: >>>>> >>>>>> Hi, >>>>>> =A0 In the plugin enabling work, we always need to exclude those >>>>>> non-bundle depdencies, and add the bundlized ones somewhere. >>>>>> =A0 But for those bundlized 3rd componenets which would publish by >>>>>> Geronimo in the folder framework/bundles, I think we may have two wa= ys, take >>>>>> org.apache.geronimo.bundles/woden-impl-dom as an example, currently,= the >>>>>> dependency setting in the pom file is like : >>>>>> =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 ${pkgGroupId} >>>>>> =A0 =A0 =A0 =A0 =A0 ${pkgArtifactId} >>>>>> =A0 =A0 =A0 =A0 =A0 ${pkgVersion} >>>>>> =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 org.apache.ant >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ant >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xerces >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xercesImpl >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xerces >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xmlParserAPIs >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 wsdl >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 wsdl >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 >>>>>> >>>>>> =A0All the non-bundlized components are excluded, so when using this >>>>>> bundle, we may also need to add the bundlized wsdl there. >>>>>> =A0While it seems that we could also add the bundlized wsdl in the p= om >>>>>> file of org.apache.geronimo.bundles/woden-impl-dom. It may be like : >>>>>> >>>>>> =A0 >>>>>> =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 ${pkgGroupId} >>>>>> =A0 =A0 =A0 =A0 =A0 ${pkgArtifactId} >>>>>> =A0 =A0 =A0 =A0 =A0 ${pkgVersion} >>>>>> =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 org.apache.ant >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ant >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xerces >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xercesImpl >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xerces >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xmlParserAPIs >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 wsdl >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 wsdl >>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 >>>>>> =A0 =A0 =A0 =A0 =A0 org.apache.servicemix.bundles >>>>>> >>>>>> org.apache.servicemix.bundles.wsdl4j >>>>>> =A0 =A0 =A0 =A0 =A0 1.6.2_2 >>>>>> =A0 =A0 =A0 >>>>>> =A0 >>>>>> >>>>>> =A0Then, when we use it, we may not need to add bundlized wsdl there= , I >>>>>> think car-maven-plugin could find it. I am thinking that we might ne= ed a >>>>>> uniform way to do it, any comment ? >>>>>> >>>>>> -- >>>>>> Ivan >>>>> >>>> >>> >>> >>> >>> -- >>> Ivan >>> >> >> >> >> -- >> Ivan >> > > > > -- > Ivan >