geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer (JIRA)" <j...@apache.org>
Subject [jira] Updated: (GERONIMO-4978) [geronimo-security] FileCertificateRequestStore inappropriately uses InputStream.available()
Date Tue, 08 Dec 2009 04:40:18 GMT

     [ https://issues.apache.org/jira/browse/GERONIMO-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nathan Beyer updated GERONIMO-4978:
-----------------------------------

    Attachment: geronimo-security-fcrs.patch

geronimo-security-fcrs.patch
This patch re-implements the getRequest method to loop over the InputStream and constructs
the Strings with the 'US-ASCII' encoding.

> [geronimo-security] FileCertificateRequestStore inappropriately uses InputStream.available()
> --------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4978
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4978
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: security
>    Affects Versions: 3.0
>            Reporter: Nathan Beyer
>         Attachments: geronimo-security-fcrs.patch
>
>
> The FileCertificateRequestStore.getRequest(String) method assumes that the value returned
by FileInputStream.available() is the entire length of the stream. This is not guaranteed
to be true.
> Additionally, the method constructs a String from a byte[] without defining a character
encoding, which means that the default encoding of the OS is used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message