Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 10858 invoked from network); 5 Nov 2009 16:13:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Nov 2009 16:13:25 -0000 Received: (qmail 42708 invoked by uid 500); 5 Nov 2009 16:13:24 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 42620 invoked by uid 500); 5 Nov 2009 16:13:24 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 42603 invoked by uid 99); 5 Nov 2009 16:13:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2009 16:13:24 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,UNPARSEABLE_RELAY X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [98.136.44.54] (HELO smtp109.prem.mail.sp1.yahoo.com) (98.136.44.54) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 05 Nov 2009 16:13:21 +0000 Received: (qmail 53846 invoked from network); 5 Nov 2009 16:13:01 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:Message-Id:From:To:In-Reply-To:Content-Type:Content-Transfer-Encoding:Mime-Version:Subject:Date:References:X-Mailer; b=sPKGRsFIK0QTZRUio8q06yxbI3pygbfrIF0sDIO0ZsRU6qNF828Mn9voYNWaLxcahgrFpvv+C9P/Gz/9+9sHf4+1VZjhR+dYi33+s+Eox4mZCpILtFCewnXtGG0NM4nWbYF71+1/snCDyWytc08zTUMZtbRCRS6xw5vuhdlK9CY= ; Received: from 72-254-92-155.client.stsn.net (david_jencks@72.254.92.155 with plain) by smtp109.prem.mail.sp1.yahoo.com with SMTP; 05 Nov 2009 08:13:00 -0800 PST X-Yahoo-SMTP: .9oIUzyswBANsYgUm_5uPui0skTnzGJXJQ-- X-YMail-OSG: LbuT0PcVM1kb8op4jS7Xb5KcrDjo1ySQd8AfKBETWHNmzQgLrYrf2uP3Fy8hGPKzJi155oBDONuPuqANk7GllQw_sCBzT98otSclRORJIYNlsOk927w9VaUFifh1p88Z9bFVOVGQnBoK44M.LD7gJlBj3AT87uHrpSFmOD8IApVQN3tPYQkTO6YxcEPW6VjmAsLyuWhbYX6s4wJkhBMRDkD7NBfjFi4dk1hR_cF1GRmQnT.OzASXYlMn2vlwfEH2JY6GS57wSyzJqLmEjJuJq4wGc6ep9yv5KRWl X-Yahoo-Newman-Property: ymail-3 Message-Id: From: David Jencks To: dev@geronimo.apache.org In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: Eliminate the ConfigurationActivator from geronimo bundles? Date: Thu, 5 Nov 2009 08:12:59 -0800 References: X-Mailer: Apple Mail (2.936) On Nov 5, 2009, at 7:17 AM, Rex Wang wrote: > IIUC, from the current design, the ConfigurationActivator will be > imported by *EVERY* geronimo plugin to help de-serialize the > config.ser into configurationData while starting. This might not be > a best practise in doing such things. > From what I see, the extender model recommended by osgi allaince is > a better choice. That is the new Geronimo kernel can be considered > as a Geronimo extender to deal with geronimo bundles, which is > fairly similar with the relationship between blueprint extender and > blueprint bundles. So if we leverage a bundle tracker to track > geronimo bundles, the bundle context and resources(i.e. config.ser) > can be easily retrieved when the bundle starting. (Just like what > dependencyManager does when install bundles. //But why read geronimo- > plugin.xml instead of config.ser there?) Then geronimo extender can > construct a configurationData from the config.ser of the geronimo > bundle and maintain a map of them. That is just the same with the > blueprint extender creating a bluepirntContainer object from OSGi- > INF/blueprint/*.xml for each blueprint bundle. > Did I miss anything or is there any particular difficulty so that we > have to use an activator? if not, I'd like to open a jira against it. I this would work but I don't see any advantage. With blueprint, you are using plain java classes and don't need any osgi specific classes available to the bundle. On the other hand gbeans are considerably more intrusive, you need either the gbean annotations or a GBeanInfo object, so we have to import a bunch of geronimo classes anyway, so there's no harm in using a geronimo specific bundle activator class too. I think there is a significant chance we might decide to try to stop using gbeans for geronimo stuff and use blueprint instead so I would rather focus on getting everything working with the existing kernel code unless we find actual problems. I'm reluctant to combine DependencyManager with the functionality of ConfigurationActivator since it seems to me that DependencyManager is very very similar to karaf features and possibly rfp 121 so we might be able to work towards combining them. thanks david jencks > > -Rex