geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rick McGuire <rick...@gmail.com>
Subject Re: svn commit: r833312 - in /geronimo/server/trunk/plugins: activemq/geronimo-activemq/pom.xml connector-1_6/connector-deployer-1_6/pom.xml connector-1_6/geronimo-connector-builder-1_6/pom.xml j2ee/geronimo-naming-builder/pom.xml
Date Fri, 06 Nov 2009 18:21:15 GMT
David Jencks wrote:
> I don't think we can use require-bundle, it conflicts with our idea of 
> using artifact-aliases.  Can you explain the problem this is trying to 
> solve?

This was the problem I highlighted in my email from a couple days ago.  
I'm also not particularly happy with using require bundle, but it 
currently looks like the best alternative available to us at the time. 

The issue here is what is necessary to get the classes generated by xml 
beans to function properly from the bundles that are using the classes.  
This requires importing all of the packages under the 
schemaorg_apache_xmlbeans directory so the xmlbeans runtime can locate 
all of the *.xsb files.  The export is easy, since bnd will handle this 
with just an export of schemaorg_apache_xmlbeans*.  However, import is a 
bit more difficult.  These packages are not directly referenced by the 
contained code, so bnd is not able to generate them automatically.  
There are also lots of package names involved with very cryptic names 
that would be quite error prone to get correct.  It would be nice if the 
bundle plugin allowed something like "import schemaorg_apache_xmlbeans* 
from bundle xyz" so that you can set things up statically at build time.

Require bundle works, but can be problematic.  In fact, I've already run 
into a situation where using require bundle caused a constraint 
violation because the wiring applied to all of the exported classes.  I 
don't think require-bundle should be the long-term solution here, but it 
gets us over the hump on being able to build things. 

Another possibility here would be to try using DynamicImport-Package.  
This was an option I didn't fully understand at the time I came up with 
the require-bundle solution.  I'll try giving that a try and see if 
things will work correctly. 

Rick
>
> thanks
> david jencks
>
> On Nov 6, 2009, at 12:17 AM, xuhaihong@apache.org wrote:
>
>> Author: xuhaihong
>> Date: Fri Nov  6 08:17:00 2009
>> New Revision: 833312
>>
>> URL: http://svn.apache.org/viewvc?rev=833312&view=rev
>> Log:
>> GERONIMO-4931 Enable ActiveMQ plugin in the OSGI environment
>> Update some import/export settings in felix-maven-plugin, also, add 
>> the geronimo-naming-builder as the required bundle of 
>> connector-deployer-1.6 to avoid the NPE
>>
>> Modified:
>>    geronimo/server/trunk/plugins/activemq/geronimo-activemq/pom.xml
>>    
>> geronimo/server/trunk/plugins/connector-1_6/connector-deployer-1_6/pom.xml 
>>
>>    
>> geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/pom.xml

>>
>>    geronimo/server/trunk/plugins/j2ee/geronimo-naming-builder/pom.xml
>>
>> Modified: 
>> geronimo/server/trunk/plugins/activemq/geronimo-activemq/pom.xml
>> URL: 
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/geronimo-activemq/pom.xml?rev=833312&r1=833311&r2=833312&view=diff

>>
>> ============================================================================== 
>>
>> --- geronimo/server/trunk/plugins/activemq/geronimo-activemq/pom.xml 
>> (original)
>> +++ geronimo/server/trunk/plugins/activemq/geronimo-activemq/pom.xml 
>> Fri Nov  6 08:17:00 2009
>> @@ -64,8 +64,9 @@
>>         </dependency>
>>
>>         <dependency>
>> -            <groupId>org.slf4j</groupId>
>> -            <artifactId>jcl-over-slf4j</artifactId>
>> +            <groupId>org.ops4j.pax.logging</groupId>
>> +            <artifactId>pax-logging-api</artifactId>
>> +            <version>1.4</version>
>>         </dependency>
>>
>>         <dependency>
>>
>> Modified: 
>> geronimo/server/trunk/plugins/connector-1_6/connector-deployer-1_6/pom.xml 
>>
>> URL: 
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/connector-1_6/connector-deployer-1_6/pom.xml?rev=833312&r1=833311&r2=833312&view=diff

>>
>> ============================================================================== 
>>
>> --- 
>> geronimo/server/trunk/plugins/connector-1_6/connector-deployer-1_6/pom.xml 
>> (original)
>> +++ 
>> geronimo/server/trunk/plugins/connector-1_6/connector-deployer-1_6/pom.xml 
>> Fri Nov  6 08:17:00 2009
>> @@ -118,7 +118,7 @@
>>                     <instructions>
>>                         <!--packages containing "impl" or "internal" 
>> are excluded by default -->
>>                         
>> <Import-Package>org.apache.xmlbeans.impl.schema;version="2.4",org.apache.geronimo.deployment.xbeans.impl,org.apache.geronimo.deployment.javabean.xbeans.impl</Import-Package>

>>
>> -                        
>> <Require-Bundle>org.apache.geronimo.framework.geronimo-service-builder</Require-Bundle>

>>
>> +                        
>> <Require-Bundle>org.apache.geronimo.framework.geronimo-service-builder,org.apache.geronimo.modules.geronimo-naming-builder</Require-Bundle>

>>
>>                         
>> <!--<_versionpolicy>[$(version;==;$(@)),$(version;+;$(@)))</_versionpolicy>-->

>>
>>                     </instructions>
>>                     <instance>
>>
>> Modified: 
>> geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/pom.xml

>>
>> URL: 
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/pom.xml?rev=833312&r1=833311&r2=833312&view=diff

>>
>> ============================================================================== 
>>
>> --- 
>> geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/pom.xml

>> (original)
>> +++ 
>> geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/pom.xml

>> Fri Nov  6 08:17:00 2009
>> @@ -100,7 +100,7 @@
>>                     <instructions>
>>                         <!--packages containing "impl" or "internal" 
>> are excluded by default -->
>>                         
>> <Import-Package>org.apache.xmlbeans.impl.schema;version="2.4",org.apache.geronimo.deployment.xbeans.impl,org.apache.geronimo.deployment.javabean.xbeans.impl,*</Import-Package>

>>
>> -                        
>> <Require-Bundle>org.apache.geronimo.framework.geronimo-service-builder</Require-Bundle>

>>
>> +                        
>> <Require-Bundle>org.apache.geronimo.framework.geronimo-service-builder,org.apache.geronimo.modules.geronimo-naming-builder</Require-Bundle>

>>
>>                         
>> <!--<_versionpolicy>[$(version;==;$(@)),$(version;+;$(@)))</_versionpolicy>-->

>>
>>                     </instructions>
>>                 </configuration>
>>
>> Modified: 
>> geronimo/server/trunk/plugins/j2ee/geronimo-naming-builder/pom.xml
>> URL: 
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/j2ee/geronimo-naming-builder/pom.xml?rev=833312&r1=833311&r2=833312&view=diff

>>
>> ============================================================================== 
>>
>> --- 
>> geronimo/server/trunk/plugins/j2ee/geronimo-naming-builder/pom.xml 
>> (original)
>> +++ 
>> geronimo/server/trunk/plugins/j2ee/geronimo-naming-builder/pom.xml 
>> Fri Nov  6 08:17:00 2009
>> @@ -73,8 +73,14 @@
>>                 <artifactId>maven-bundle-plugin</artifactId>
>>                 <configuration>
>>                     <instructions>
>> -                        
>> <Import-Package>org.apache.xmlbeans.impl.schema;version="2.4",*</Import-Package>

>>
>>                         
>> <!--<_versionpolicy>[$(version;==;$(@)),$(version;+;$(@)))</_versionpolicy>-->

>>
>> +                        
>> <Import-Package>org.apache.xmlbeans.impl.schema,*</Import-Package>
>> +                        <Export-Package>
>> +                            schemaorg_apache_xmlbeans*,
>> +                            
>> org.apache.geronimo.xbeans.geronimo.naming*,
>> +                            
>> org.apache.geronimo.xbeans.geronimo.naming.impl,
>> +                            org.apache.geronimo.naming.deployment*
>> +                        </Export-Package>
>>                     </instructions>
>>                 </configuration>
>>             </plugin>
>>
>>
>
>


Mime
View raw message