Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <1669230690.1256542439462.JavaMail.jira@brutus>
Date: Mon, 26 Oct 2009 07:33:59 +0000 (UTC)
From: "David Jencks (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Assigned: (GERONIMO-4928) In the JPA persistence.xml loading
 code, exclude-unlisted-classes handling not compliant with JPA3.0 spec
In-Reply-To: <1076440946.1256330759497.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/GERONIMO-4928?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks reassigned GERONIMO-4928:
--------------------------------------

    Assignee: David Jencks

> In the JPA persistence.xml loading code, exclude-unlisted-classes handlin=
g not compliant with JPA3.0 spec
> -------------------------------------------------------------------------=
--------------------------------
>
>                 Key: GERONIMO-4928
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4928
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)=20
>          Components: deployment, persistence
>    Affects Versions: 2.1.4
>            Reporter: Quintin Beukes
>            Assignee: David Jencks
>             Fix For: 2.1.4, 2.2, 3.0
>
>         Attachments: external-jpa-entity-reference.patch
>
>
> {panel:title=3DEJB 3.0 JPA spec FR, section 6.2.1.6}
> The set of managed persistence classes that are managed by a persistence =
unit is defined by using one or
> more of the following:[41]
>      =E2=80=A2 One or more object/relational mapping XML files
>      =E2=80=A2 One or more jar files that will be searched for classes
>      =E2=80=A2 An explicit list of the classes
>      =E2=80=A2 The annotated managed persistence classes contained in the=
 root of the persistence unit (unless
>          the exclude-unlisted-classes element is specified)
> {panel}
> {panel:title=3Dfurther on in the same section}
> All classes must be on the classpath to ensure that entity managers from =
different persistence units that
> map the same class will be accessing the same identical class.
> {panel}
> This says that if exclude-unlisted-classes is specified as true, then onl=
y the classes listed in <class> elements must be used in the PU. If it is s=
pecified as false, then the annotated classes must be included. It's the on=
ly thing that exclude-unlisted-classes affects. It doesn't affect classes f=
rom other units, and if false it doesn't say that <class> must be ignored, =
which is what the following code does in PersistenceUnitBuilder.java:
> {code:title=3DPersistenceUnitBuilder.java line 310|borderStyle=3Dsolid}
> if (excludeUnlistedClasses) {
>     gbeanData.clearAttribute("jarFileUrls");
> } else {
>     gbeanData.clearAttribute("managedClassNames");
> }
> {code}
> I removed the else block to leave:
> {code:title=3DPersistenceUnitBuilder.java Patched|borderStyle=3Dsolid}
> if (excludeUnlistedClasses) {
>     gbeanData.clearAttribute("jarFileUrls");
> }
> {code}
> Without this Geronimo isn't JavaEE 5 compliant.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.