geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <david_jen...@yahoo.com>
Subject Re: svn commit: r829712 - /geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/DependencyManager.java
Date Mon, 26 Oct 2009 17:04:16 GMT

On Oct 26, 2009, at 12:54 AM, Ivan wrote:

> While starting Geroniom, System.getProperty("geronimo.build.car")  
> always return null for it is not set. So the mvn style url is always  
> returned, not the file reference url.

That's intentional.  IMO we should be using the mvn: pax urls in  
actual geronimo.  We should also fix the build so it uses them.   
Finally we should figure out how to make the pax mvn url handler use  
references rather than copying the bundles.  I don't know if this is a  
configuration issue or if we need to change the pax code.

thanks
david jencks

>
> 2009/10/26 David Jencks <david_jencks@yahoo.com>
> I'm confused as to how this is relevant to using references rather  
> than copied bundles.  My goals here are to convert the build to use  
> mvn urls, and to get the mvn urls to use bundle references.  I don't  
> see how this change gets us any closer to this goal.
>
> thanks
> david jencks
>
>
> On Oct 26, 2009, at 12:17 AM, xuhaihong@apache.org wrote:
>
> Author: xuhaihong
> Date: Mon Oct 26 07:17:05 2009
> New Revision: 829712
>
> URL: http://svn.apache.org/viewvc?rev=829712&view=rev
> Log:
> GERONIMO-4921 Use the reference file URL for bundle loading on the  
> runtime
>
> Modified:
>   geronimo/server/trunk/framework/modules/geronimo-system/src/main/ 
> java/org/apache/geronimo/system/configuration/DependencyManager.java
>
> Modified: geronimo/server/trunk/framework/modules/geronimo-system/ 
> src/main/java/org/apache/geronimo/system/configuration/ 
> DependencyManager.java
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/configuration/DependencyManager.java?rev=829712&r1=829711&r2=829712&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- geronimo/server/trunk/framework/modules/geronimo-system/src/main/ 
> java/org/apache/geronimo/system/configuration/DependencyManager.java  
> (original)
> +++ geronimo/server/trunk/framework/modules/geronimo-system/src/main/ 
> java/org/apache/geronimo/system/configuration/DependencyManager.java  
> Mon Oct 26 07:17:05 2009
> @@ -118,7 +118,7 @@
>    }
>
>    private String locateBundle(Artifact configurationId) throws  
> NoSuchConfigException, IOException, InvalidConfigException {
> -        if (System.getProperty("geronimo.build.car") == null) {
> +        if  
> (Boolean.valueOf(System.getProperty("geronimo.build.car"))) {
>            return "mvn:" + configurationId.getGroupId() + "/" +  
> configurationId.getArtifactId() + "/" + configurationId.getVersion()  
> + ("jar".equals(configurationId.getType())?  "": "/" +  
> configurationId.getType());
>        }
>        for (Repository repo : repositories) {
>
>
>
>
>
>
> -- 
> Ivan


Mime
View raw message