geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jack Cai (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-4874) Improve the console filter performance
Date Wed, 23 Sep 2009 04:02:16 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758572#action_12758572
] 

Jack Cai commented on GERONIMO-4874:
------------------------------------

Thanks Ivan!

And we can now remove the below two files:
plugins/console/console-filter/src/main/java/org/apache/geronimo/console/filter/FilterResponseWrapper.java
plugins/console/console-filter/src/main/java/org/apache/geronimo/console/filter/ResponseOutputStream.java

> Improve the console filter performance
> --------------------------------------
>
>                 Key: GERONIMO-4874
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4874
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 2.1.4, 2.1.5, 2.2, 3.0
>         Environment: All
>            Reporter: Jack Cai
>            Priority: Minor
>             Fix For: 2.1.5, 2.2, 3.0
>
>         Attachments: GERONIMO-4874.patch, GERONIMO-4874_0918.patch
>
>
> Current console filter for blocking XSRF attack does not scale well as it need to read
all the output into a string and then do some text replacement. This will use a lot of memory
in extreme cases. See the discussion [1].
> [1] http://www.nabble.com/XSRFHandler-question-td24545409s134.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message