Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: domain of jgawor@gmail.com designates
 209.85.132.241 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=Gu21RTdmbRD9bRQAC70Fq/Y4CY1p4TSc32BccPYKJtQ2reU4GUs9gUYUwCekvj6YzY
         CE6Nh/2tD8F6b5+5YJytSkY01K8pQLQx9dImvJ6LMv6/MvomjPIEcDR3HTaFKdKwC6AY
         qtzCPALyHi2vV6X8Z+bbHkIi16AiLYYXKaLCA=
MIME-Version: 1.0
In-Reply-To: <45f744e40906292312h359d75c7l852b73a1bcedf937@mail.gmail.com>
References: <5eb405c70906292234h153a53fq9e8c4242acd400c8@mail.gmail.com>
	 <45f744e40906292312h359d75c7l852b73a1bcedf937@mail.gmail.com>
Date: Wed, 1 Jul 2009 01:03:33 -0400
Message-ID: <5eb405c70906302203l65c1f75ana7b4bf12583e4aed@mail.gmail.com>
Subject: Re: admin console and prompting
From: Jarek Gawor <jgawor@gmail.com>
To: dev@geronimo.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

If Dojo is only used to display a nice box in this case, I think we
should just get rid off it and use the regular dialog boxes.

Jarek

On Tue, Jun 30, 2009 at 2:12 AM, Ivan<xhhsld@gmail.com> wrote:
> I checked the codes of ConfirmMessageTag, its main purpose is to import Dojo
> js file and some styles for showing Dojo box.
> 1. When dojo is not installed, I do not think the confirm box could work.
> For the showConfirmMessage function uses some Dojo components.
> 2. The name seems not conformable with its function. I agree that we should
> change it to be more valid.
> Ivan
>
> 2009/6/30 Jarek Gawor <jgawor@gmail.com>
>>
>> Hi,
>>
>> While debugging the console testsuites I realized that the admin
>> console was no longer prompting when uninstalling a given module (or
>> stopping or restarting). I tracked down the problem to
>> ConfirmMessageTag.java where it was pointing to wrong locations for
>> Dojo resources. Now, I have a few of questions about this
>> ConfirmMessageTag that I'm hoping somebody will be able to answer:
>>
>> 1) Is it necessary for ConfirmMessageTag to use Dojo? Or at least can
>> we make it so that it still works (displays prompts) when Dojo is not
>> installed?
>>
>> 2) The ConfirmMessageTag injects a <style/> element into the page body
>> (within <body/>). But from what I can tell (and I checked this with
>> jslint) the <style/> elements only should appear within the <head/>
>> element. Things seems to work the way they are now but I'm wondering
>> if we should change this to be more valid.
>>
>> Jarek
>
>
>
> --
> Ivan
>