Return-Path: 
 <dev-return-74770-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 35268 invoked from network); 10 Jul 2009 05:36:30 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 10 Jul 2009 05:36:30 -0000
Received: (qmail 72927 invoked by uid 500); 10 Jul 2009 05:36:40 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 72831 invoked by uid 500); 10 Jul 2009 05:36:39 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 72823 invoked by uid 99); 10 Jul 2009 05:36:39 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jul 2009 05:36:39 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jul 2009 05:36:36 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id DDBC8234C044
	for <dev@geronimo.apache.org>; Thu,  9 Jul 2009 22:36:14 -0700 (PDT)
Message-ID: <1878998946.1247204174907.JavaMail.jira@brutus>
Date: Thu, 9 Jul 2009 22:36:14 -0700 (PDT)
From: "Shawn Jiang (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-4737) geronimo-commands module should
 inherit filter settings from genesis.
In-Reply-To: <1842245257.1247203816340.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/GERONIMO-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729528#action_12729528 ] 

Shawn Jiang commented on GERONIMO-4737:
---------------------------------------

I also searched and found many duplicated filter setting that might be conflict with genesis filter settings:

E:\src\gt\plugins\cxf\geronimo-cxf-tools\pom.xml (1 hits)
	Line 63:                 <filtering>true</filtering>
\gt\plugins\tomcat\tomcat6\pom.xml (1 hits)
	Line 117:                 <filtering>true</filtering>
\gt\plugins\tomcat\tomcat6-deployer\pom.xml (1 hits)
	Line 80:                 <filtering>true</filtering>
\gt\plugins\welcome\welcome-tomcat\pom.xml (1 hits)
	Line 87:                 <filtering>true</filtering>
\gt\plugins\welcome\welcome-jetty\pom.xml (1 hits)
	Line 87:                 <filtering>true</filtering>
\gt\plugins\dojo-legacy\dojo-legacy-tomcat\pom.xml (1 hits)
	Line 71:                 <filtering>true</filtering>
\gt\plugins\dojo-legacy\dojo-legacy-jetty\pom.xml (1 hits)
	Line 71:                 <filtering>true</filtering>
\gt\plugins\debugviews\debugviews-console-jetty\pom.xml (1 hits)
	Line 101:                 <filtering>true</filtering>
\gt\plugins\debugviews\debugviews-console-tomcat\pom.xml (1 hits)
	Line 95:                 <filtering>true</filtering>
\gt\plugins\debugviews\debugviews-portlets\pom.xml (1 hits)
	Line 116:                 <filtering>true</filtering>
\gt\plugins\activemq\activemq-portlets\pom.xml (1 hits)
	Line 108:                 <filtering>true</filtering>
\gt\plugins\activemq\activemq-console-jetty\pom.xml (1 hits)
	Line 157:                 <filtering>true</filtering>
\gt\plugins\activemq\activemq-console-tomcat\pom.xml (1 hits)
	Line 148:                 <filtering>true</filtering>
\gt\plugins\plancreator\plancreator-console-tomcat\pom.xml (1 hits)
	Line 99:                 <filtering>true</filtering>
\gt\plugins\plancreator\plancreator-portlets\pom.xml (1 hits)
	Line 152:                 <filtering>true</filtering>
\gt\plugins\plancreator\plancreator-console-jetty\pom.xml (1 hits)
	Line 107:                 <filtering>true</filtering>
\gt\plugins\openejb\geronimo-openejb\pom.xml (1 hits)
	Line 162:                 <filtering>true</filtering>
\gt\plugins\openejb\openejb-console-jetty\pom.xml (1 hits)
	Line 94:                 <filtering>true</filtering>
\gt\plugins\openejb\openejb-console-tomcat\pom.xml (1 hits)
	Line 94:                 <filtering>true</filtering>
\gt\plugins\openejb\openejb-portlets\pom.xml (1 hits)
	Line 144:                 <filtering>true</filtering>
\gt\plugins\monitoring\mconsole-war\pom.xml (1 hits)
	Line 109:                 <filtering>true</filtering>
\gt\plugins\monitoring\agent-sql\pom.xml (1 hits)
	Line 43:                 <!-- <filtering>true</filtering> -->
\gt\plugins\monitoring\pom.xml (1 hits)
	Line 81:                 <filtering>true</filtering>
\gt\plugins\system-database\sysdb-console-jetty\pom.xml (1 hits)
	Line 254:                 <filtering>true</filtering>
\gt\plugins\system-database\system-database\pom.xml (1 hits)
	Line 97:                 <filtering>true</filtering>
\gt\plugins\system-database\sysdb-console-tomcat\pom.xml (1 hits)
	Line 239:                 <filtering>true</filtering>
\gt\plugins\system-database\sysdb-portlets\pom.xml (1 hits)
	Line 143:                 <filtering>true</filtering>
\gt\plugins\dojo\dojo-tomcat\pom.xml (1 hits)
	Line 71:                 <filtering>true</filtering>
\gt\plugins\dojo\dojo-jetty\pom.xml (1 hits)
	Line 71:                 <filtering>true</filtering>
\gt\plugins\openjpa\openjpa\pom.xml (1 hits)
	Line 82:                 <filtering>true</filtering>
\gt\plugins\jaxws\geronimo-jaxws-sun-tools\pom.xml (1 hits)
	Line 53:                 <filtering>true</filtering>
\gt\plugins\ca-helper\ca-helper-tomcat\pom.xml (1 hits)
	Line 78:                 <filtering>true</filtering>
\gt\plugins\ca-helper\ca-helper-jetty\pom.xml (1 hits)
	Line 78:                 <filtering>true</filtering>
\gt\plugins\console\console-jetty\pom.xml (1 hits)
	Line 127:                 <filtering>true</filtering>
\gt\plugins\console\plugin-console-tomcat\pom.xml (1 hits)
	Line 96:                 <filtering>true</filtering>
\gt\plugins\console\console-base-portlets\pom.xml (1 hits)
	Line 108:                 <filtering>true</filtering>
\gt\plugins\console\console-tomcat\pom.xml (1 hits)
	Line 127:                 <filtering>true</filtering>
\gt\plugins\console\plugin-portlets\pom.xml (1 hits)
	Line 135:                 <filtering>true</filtering>
\gt\plugins\console\console-portal-driver\pom.xml (1 hits)
	Line 100:                             <filtering>true</filtering>
\gt\plugins\console\plugin-console-jetty\pom.xml (1 hits)
	Line 96:                 <filtering>true</filtering>
\gt\plugins\mejb\geronimo-mejb\pom.xml (1 hits)
	Line 41:                 <filtering>true</filtering>
\gt\plugins\mejb\mejb\pom.xml (1 hits)
	Line 69:                 <filtering>true</filtering>
\gt\testsuite\webservices-testsuite\jaxws-wsa-tests\wsa-ejb\pom.xml (1 hits)
	Line 61:                 <filtering>true</filtering>
\gt\testsuite\webservices-testsuite\jaxws-mtom-tests\mtom-test-war\pom.xml (1 hits)
	Line 44:                 <filtering>false</filtering>
\gt\testsuite\webservices-testsuite\jaxws-mtom-tests\mtom-ejb\pom.xml (1 hits)
	Line 59:                 <filtering>true</filtering>
\gt\testsuite\pom.xml (2 hits)
	Line 88:                 <filtering>true</filtering>
	Line 110:                                 <filtering>true</filtering>
\gt\testsupport\test-deployment-j2ee_1.3\test-ear-j2ee_1.3\pom.xml (1 hits)
	Line 68:                 <filtering>true</filtering>
\gt\testsupport\test-deployment-j2ee_1.4\test-ear-j2ee_1.4\pom.xml (1 hits)
	Line 68:                 <filtering>true</filtering>
\gt\testsupport\test-deployment-javaee_5\test-ear-javaee_5\pom.xml (1 hits)
	Line 68:                 <filtering>true</filtering>



We might want to remove those filter setting in individual pom.xml so that sub project can reuse the filter setting in genesis.

> geronimo-commands module should inherit filter settings from genesis.
> ---------------------------------------------------------------------
>
>                 Key: GERONIMO-4737
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4737
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: buildsystem
>    Affects Versions: 2.2
>            Reporter: Shawn Jiang
>            Assignee: Shawn Jiang
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: G4737.patch
>
>
> geronimo-commands  has is own filter setting in pom.xml.  The settings have conflicts:
> {code}
> <resources>
>             <resource>
>                 <directory>${pom.basedir}/src/main/resources</directory>
>                 <includes>
>                     <include>**/*</include>
>                 </includes>
>             </resource>
>             <resource>
>                 <directory>${pom.basedir}/src/main/resources</directory>
>                 <filtering>true</filtering>
>                 <includes>
>                     <include>org/apache/geronimo/commands/version.properties</include>
>                 </includes>
>             </resource>
> {code}
> One is <filtering>false</filtering>, the other is <filtering>true</filtering>.   This will result in filter setting merge error sometime.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.