geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jack Cai <greensi...@gmail.com>
Subject Re: [jira] Commented: (GERONIMO-4769) Add English resource bundle for Admin console
Date Wed, 29 Jul 2009 11:40:08 GMT
En, good idea. Agree to generate the en resources on the fly.

As to the "trick code", I don't see any in the current code. The JSPs soley
depends on the <fmt:message> tag to load the resource bundles. We could
reset system's default locale to "en_US", which is not a good idea to me
though.

On Wed, Jul 29, 2009 at 4:26 PM, Shawn Jiang (JIRA) <jira@apache.org> wrote:

>
>    [
> https://issues.apache.org/jira/browse/GERONIMO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736527#action_12736527]
>
> Shawn Jiang commented on GERONIMO-4769:
> ---------------------------------------
>
> Firstly, I'd like to fix the i18n resource bundle before fixing this
> because the i18n patch is very hard to create. : )
>
> Secondly, I agree with Ivan that we could copy and rename these resource
> file at build time instead of duplicated files. Seem only regex based move
> ant task could do the trick.
>
> > Add English resource bundle for Admin console
> > ---------------------------------------------
> >
> >                 Key: GERONIMO-4769
> >                 URL: https://issues.apache.org/jira/browse/GERONIMO-4769
> >             Project: Geronimo
> >          Issue Type: Bug
> >      Security Level: public(Regular issues)
> >          Components: console
> >    Affects Versions: 2.1.5, 2.2
> >            Reporter: Jack Cai
> >            Priority: Minor
> >         Attachments: GERONIMO-4769_21.patch, GERONIMO-4769_trunk.patch
> >
> >
> > The resource bundle search logic will consider default locale before
> falling back to the base resource bundle. This means if Geronimo is running
> on a Chinese OS with locale "zh_CN", when a user visits the admin console
> with "en_US" as the browser locale, the user will actually see the admin
> console in Chinese!
> > To avoid this problem, we shall duplicate the base resource bundles with
> the name *en.properties.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Mime
View raw message