Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 92867 invoked from network); 10 Jun 2009 05:59:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Jun 2009 05:59:02 -0000 Received: (qmail 39930 invoked by uid 500); 10 Jun 2009 05:59:13 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 39849 invoked by uid 500); 10 Jun 2009 05:59:13 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 39841 invoked by uid 99); 10 Jun 2009 05:59:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jun 2009 05:59:13 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of rwonly@gmail.com designates 209.85.198.237 as permitted sender) Received: from [209.85.198.237] (HELO rv-out-0506.google.com) (209.85.198.237) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jun 2009 05:59:04 +0000 Received: by rv-out-0506.google.com with SMTP id l9so2292906rvb.3 for ; Tue, 09 Jun 2009 22:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=mSqh24XLKZHlZFzvClFtDB5EP6Agodxf4jBO6qIAkTI=; b=ZBHO+8Sw6Ls6jl0xyfaCIORd/mW2BnvtLntj9zUhRnDP9RjoiGMmFzI9TfmsRL1gt5 ByB1jvveXR8FKrqku4cPnMgxn1dyoeiPEZ7cf2th2LtxyHQ24oIi271NaOCs77EoPegi 7fvCZUE/jSlUVRN+LZZCUFSa0qgFXh/+dbhtA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=w4Pc3IkPsNw+9CKPQ38djprB+fIusYxUdNNocZrIGH8zPWjrmxHkb78bI/SpY8Jj9Y bRr6Pt4IuTa7ijs94MlYRpAkVi6ByjOkQN/CAt7D82421iVsoE1UMgw5ve9HQmBMrIte dQ0TqxTGjNXUtn6cH2wiaBPxds/p6ZUwiddcU= MIME-Version: 1.0 Received: by 10.141.82.20 with SMTP id j20mr819825rvl.138.1244613521763; Tue, 09 Jun 2009 22:58:41 -0700 (PDT) In-Reply-To: <340750179.1244609347385.JavaMail.jira@brutus> References: <581647570.1244455207709.JavaMail.jira@brutus> <340750179.1244609347385.JavaMail.jira@brutus> Date: Wed, 10 Jun 2009 13:58:41 +0800 Message-ID: Subject: Re: [jira] Commented: (GERONIMO-4679) many [ERROR] "The protocol for the JAR file's URL is not supported" in the build log when building geronimo on windows From: Rex Wang To: dev@geronimo.apache.org Content-Type: multipart/alternative; boundary=000e0cd15606d8efdc046bf82a48 X-Virus-Checked: Checked by ClamAV on apache.org --000e0cd15606d8efdc046bf82a48 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I agree -Rex 2009/6/10 Shawn Jiang (JIRA) > > [ > https://issues.apache.org/jira/browse/GERONIMO-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717915#action_12717915] > > Shawn Jiang commented on GERONIMO-4679: > --------------------------------------- > > The stacktrace in warn will flood the build log if using warn here. Maybe > we can use following code to just warn a simple message and redirect the > stacktrace to debug. > > log.warn(URl:"+url.toString()+" is not supported); > log.debug("URl:"+url.toString()+" is not supported",ex); > > What do you think ? > > > many [ERROR] "The protocol for the JAR file's URL is not supported" in > the build log when building geronimo on windows > > > ----------------------------------------------------------------------------------------------------------------------- > > > > Key: GERONIMO-4679 > > URL: https://issues.apache.org/jira/browse/GERONIMO-4679 > > Project: Geronimo > > Issue Type: Improvement > > Security Level: public(Regular issues) > > Components: kernel > > Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.1.4 > > Environment: windows + trunk > > Reporter: Shawn Jiang > > Assignee: Shawn Jiang > > Priority: Minor > > Fix For: 2.1.5, 2.2 > > > > Attachments: G4679.patch > > > > > > When building the Geronimo from source code on windows. There are > > many [ERROR] "The protocol for the JAR file's URL is not supported" in > > the build log like following. > > ------------------------------------- > > [ERROR] The protocol for the JAR file's URL is not supported > > java.lang.UnsupportedOperationException: Only local file jars are > > supported jar:file:/D:/ws/gtrunck/ > > server_repo/org/apache/geronimo/configs/system-database/2.2-SNAPSHOT/ > > system-database-2.2-SNAPSHOT.ca > > r!/rar/tranql-connector-1.4.jar > > > > > org.apache.geronimo.kernel.classloader.UrlResourceFinder.cacheUrl(UrlResourceFinder.java:231) > > > > > org.apache.geronimo.kernel.classloader.UrlResourceFinder.rebuildClassPath(UrlResourceFinder.java > > :188) > > > > > org.apache.geronimo.kernel.classloader.UrlResourceFinder.addUrls(UrlResourceFinder.java:142) > > > > > org.apache.geronimo.kernel.classloader.UrlResourceFinder.addUrls(UrlResourceFinder.java:127) > > > > > org.apache.geronimo.kernel.classloader.JarFileClassLoader$2.run(JarFileClassLoader.java:153) > > ---------------------------------------- > > This message was thrown in UrlResourceFinder.cacheUrl() and logged as > > ERROR in UrlResourceFinder.rebuildClassPath(). > > -------------------------------------- > > } catch (UnsupportedOperationException ex) { > > // the protocol for the JAR file's URL is not > > supported. This can occur when > > // the jar file is embedded in an EAR or CAR > > file. Proceed but log the message. > > log.error("The protocol for the JAR file's URL > > is not supported", ex); > > continue; > > } > > ----------------------------------------- > > We'd better to log this as INFO or DEBUG instead of an ERROR so that the > user will not be mislead by a lot of ERRORs in the build log. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > --000e0cd15606d8efdc046bf82a48 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I agree
-Rex



2009/6/10 Shawn J= iang (JIRA) <jira@a= pache.org>

=A0 =A0[ https://issue= s.apache.org/jira/browse/GERONIMO-4679?page=3Dcom.atlassian.jira.plugin.sys= tem.issuetabpanels:comment-tabpanel&focusedCommentId=3D12717915#action_= 12717915 ]

Shawn Jiang commented on GERONIMO-4679:
---------------------------------------

The stacktrace in warn will flood the build log if using warn here. =A0Mayb= e we can use following code to just warn a simple message and redirect the = stacktrace to debug.

log.warn(URl:"+url.toString()+" is not supported);
log.debug("URl:"+url.toString()+" is not supported",ex)= ;

What do you think ?

> many [ERROR] "The protocol for the JAR file's URL is not supp= orted" in =A0the build log when building geronimo on windows
> ----------------------------------------------------------------------= -------------------------------------------------
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Key: GERONIMO-4679
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 URL: https://issues.apache.org/= jira/browse/GERONIMO-4679
> =A0 =A0 =A0 =A0 =A0 =A0 Project: Geronimo
> =A0 =A0 =A0 =A0 =A0Issue Type: Improvement
> =A0 =A0 =A0Security Level: public(Regular issues)
> =A0 =A0 =A0 =A0 =A0Components: kernel
> =A0 =A0Affects Versions: 2.1.1, 2.1.2, 2.1.3, 2.1.4
> =A0 =A0 =A0 =A0 Environment: windows + trunk
> =A0 =A0 =A0 =A0 =A0 =A0Reporter: Shawn Jiang
> =A0 =A0 =A0 =A0 =A0 =A0Assignee: Shawn Jiang
> =A0 =A0 =A0 =A0 =A0 =A0Priority: Minor
> =A0 =A0 =A0 =A0 =A0 =A0 Fix For: 2.1.5, 2.2
>
> =A0 =A0 =A0 =A0 Attachments: G4679.patch
>
>
> When building the Geronimo from source code on windows. =A0There are > many [ERROR] "The protocol for the JAR file's URL is not supp= orted" in
> the build log like following.
> -------------------------------------
> [ERROR] The protocol for the JAR file's URL is not supported
> java.lang.UnsupportedOperationException: Only local file jars are
> supported jar:file:/D:/ws/gtrunck/
> server_repo/org/apache/geronimo/configs/system-database/2.2-SNAPSHOT/<= br> > s= ystem-database-2.2-SNAPSHOT.ca
> r!/rar/tranql-connector-1.4.jar
>
> org.apache.geronimo.kernel.classloader.UrlResourceFinder.cacheUrl(UrlR= esourceFinder.java:231)
>
> org.apache.geronimo.kernel.classloader.UrlResourceFinder.rebuildClassP= ath(UrlResourceFinder.java
> :188)
>
> org.apache.geronimo.kernel.classloader.UrlResourceFinder.addUrls(UrlRe= sourceFinder.java:142)
>
> org.apache.geronimo.kernel.classloader.UrlResourceFinder.addUrls(UrlRe= sourceFinder.java:127)
>
> org.apache.geronimo.kernel.classloader.JarFileClassLoader$2.run(JarFil= eClassLoader.java:153)
> ----------------------------------------
> This message was thrown in =A0UrlResourceFinder.cacheUrl() and logged = as
> ERROR in UrlResourceFinder.rebuildClassPath().
> --------------------------------------
> =A0} catch (UnsupportedOperationException ex) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0// the protocol for the= JAR file's URL is not
> supported. =A0This can occur when
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0// the jar file is embe= dded in an EAR or CAR
> file. =A0Proceed but log the message.
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0log.error("The pro= tocol for the JAR file's URL
> is not supported", ex);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0continue;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}
> -----------------------------------------
> We'd better to log this as INFO or DEBUG instead of an ERROR so th= at the user will not be mislead by a lot of ERRORs in the build log.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


--000e0cd15606d8efdc046bf82a48--