Return-Path: 
 <dev-return-74309-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 51916 invoked from network); 23 Jun 2009 14:18:22 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 23 Jun 2009 14:18:22 -0000
Received: (qmail 23621 invoked by uid 500); 23 Jun 2009 14:18:32 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 23519 invoked by uid 500); 23 Jun 2009 14:18:32 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 23503 invoked by uid 99); 23 Jun 2009 14:18:32 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2009 14:18:32 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of greensight@gmail.com
 designates 74.125.46.29 as permitted sender)
Received: from [74.125.46.29] (HELO yw-out-2324.google.com) (74.125.46.29)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2009 14:18:24 +0000
Received: by yw-out-2324.google.com with SMTP id 2so35433ywt.85
        for <dev@geronimo.apache.org>; Tue, 23 Jun 2009 07:18:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:content-type;
        bh=66MXfzCkB1ktOODnKhsCY2HFPSKLh4Z9RwN+nEU6E2A=;
        b=wHW1Ezx/NBrN1njtXOX7XuMZELkSs72Ifu1TIIP8GjXfdR2Iumw7/Z1dDs8U3Gt4PF
         ggmvmUs5WILYedm0FKz6iTphY/YwnEtwpJxmcIh5ouFiP4pZFwhtG6kmDudi3LS8qMgP
         XkTs3IIMjlAuJMTeoGpFj0wT8LlwVMQoJLudU=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=Cx4meXAhJL8a0fraOmHN+iC6LVsPe+caC4jgtkECP5Qv1NXhgb5v9PVVN1ZsNO+Wlx
         zf9rV3CRNXvgXAaz1KYarMKubquKfzRERVZRuitsdl4moNb3SAGkufPkj0c4JyI+RQMV
         45DzdicX8rEiR4ldfxaf4kfxLZlh80819voo8=
MIME-Version: 1.0
Received: by 10.151.72.2 with SMTP id z2mr366430ybk.3.1245766683479; Tue, 23
	Jun 2009 07:18:03 -0700 (PDT)
In-Reply-To: <fbab58220906230606w5dd87da9j4ce2764e0f2665f8@mail.gmail.com>
References: <fbab58220906230606w5dd87da9j4ce2764e0f2665f8@mail.gmail.com>
Date: Tue, 23 Jun 2009 22:18:03 +0800
Message-ID: <5e7fd1eb0906230718w7aea5debk94a46026924519a2@mail.gmail.com>
Subject: Re: Build the GBeanInfo with the attribute name caselessly?
From: Jack Cai <greensight@gmail.com>
To: dev@geronimo.apache.org
Content-Type: multipart/alternative; boundary=001e680f1700a450bc046d04a855
X-Virus-Checked: Checked by ClamAV on apache.org

--001e680f1700a450bc046d04a855
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Looks like a good idea to me.

-Jack

On Tue, Jun 23, 2009 at 9:06 PM, Rex Wang <rwonly@gmail.com> wrote:

> Build the GBeanInfo with the attribute name caselessly?
>
> Currently, we build the GBeanInfo attribute according to the java code
> convention. However, we user set the attribute throught the plan, he have to
> pay attention to the case of the attribute name, such as:
>         <gbean name="SMTPTransport">
>             <attribute name="host">${SMTPHost}</attribute>
>             <attribute name="port">${SMTPPort}</attribute>
>         </gbean>
> and
>         <gbean
> name="org.apache.geronimo.configs/tomcat6/2.1.5-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/tomcat6/2.1.5-SNAPSHOT/car,j2eeType=GBean,name=uniquename2"
> load="false"
> gbeanInfo="org.apache.geronimo.tomcat.connector.Http11ConnectorGBean">
>             <attribute name="keepAliveTimeout">60000</attribute>
>             <attribute name="maxThreads">40</attribute>
>             <attribute name="acceptCount">10</attribute>
>             <attribute name="connectionTimeout">60000</attribute>
>             <attribute name="connectionLinger">-1</attribute>
>             <attribute name="address">0.0.0.0</attribute>
>
> but we it comes to the ra.xml, we always use the first upper case word to
> define the properties, such as:
>         <config-property-name>DatabaseName</config-property-name>
>         <config-property-type>java.lang.String</config-property-type>
> and that causes the program logic in the config module builder should deal
> with that specificly...programmer might hate that..
>
> So, if either the user or developer will get un-happyness on this
> configuration, why not we build the GBeanInfo with a caseless name
> indentifid GAttributeInfo?
>
> -Rex
> Jun 23
>

--001e680f1700a450bc046d04a855
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Looks like a good idea to me.<br><br>-Jack<br><br><div class=3D"gmail_quote=
">On Tue, Jun 23, 2009 at 9:06 PM, Rex Wang <span dir=3D"ltr">&lt;<a href=
=3D"mailto:rwonly@gmail.com">rwonly@gmail.com</a>&gt;</span> wrote:<br><blo=
ckquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, 204,=
 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Build the GBeanInfo with the attribute name caselessly?<br><br>Currently, w=
e build the GBeanInfo attribute according to the java code convention. Howe=
ver, we user set the attribute throught the plan, he have to pay attention =
to the case of the attribute name, such as:<br>

=A0=A0=A0=A0=A0=A0=A0 &lt;gbean name=3D&quot;SMTPTransport&quot;&gt;<br>=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;attribute name=3D&quot;host&quot;&gt;${S=
MTPHost}&lt;/attribute&gt;<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;attribu=
te name=3D&quot;port&quot;&gt;${SMTPPort}&lt;/attribute&gt;<br>

=A0=A0=A0=A0=A0=A0=A0 &lt;/gbean&gt;<br>and<br>=A0=A0=A0=A0=A0=A0=A0 &lt;gb=
ean name=3D&quot;org.apache.geronimo.configs/tomcat6/2.1.5-SNAPSHOT/car?Ser=
viceModule=3Dorg.apache.geronimo.configs/tomcat6/2.1.5-SNAPSHOT/car,j2eeTyp=
e=3DGBean,name=3Duniquename2&quot; load=3D&quot;false&quot; gbeanInfo=3D&qu=
ot;org.apache.geronimo.tomcat.connector.Http11ConnectorGBean&quot;&gt;<br>

=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;attribute name=3D&quot;keepAliveTimeo=
ut&quot;&gt;60000&lt;/attribute&gt;<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &l=
t;attribute name=3D&quot;maxThreads&quot;&gt;40&lt;/attribute&gt;<br>=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;attribute name=3D&quot;acceptCount&quot;&gt=
;10&lt;/attribute&gt;<br>

=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;attribute name=3D&quot;connectionTime=
out&quot;&gt;60000&lt;/attribute&gt;<br>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &=
lt;attribute name=3D&quot;connectionLinger&quot;&gt;-1&lt;/attribute&gt;<br=
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 &lt;attribute name=3D&quot;address&quot;=
&gt;0.0.0.0&lt;/attribute&gt;<br>

<br>but we it comes to the ra.xml, we always use the first upper case word =
to define the properties, such as:<br>=A0=A0=A0=A0=A0=A0=A0 &lt;config-prop=
erty-name&gt;DatabaseName&lt;/config-property-name&gt;<br>=A0=A0=A0=A0=A0=
=A0=A0 &lt;config-property-type&gt;java.lang.String&lt;/config-property-typ=
e&gt;<br>

and that causes the program logic in the config module builder should deal =
with that specificly...programmer might hate that..<br><br>So, if either th=
e user or developer will get un-happyness on this configuration, why not we=
 build the GBeanInfo with a caseless name indentifid GAttributeInfo?<br>

<br>-Rex<br>Jun 23<br>
</blockquote></div><br>

--001e680f1700a450bc046d04a855--