On Jun 19, 2009, at 12:13 AM, Shawn Jiang wrote:

Can anyone shed some light on this ?

The entire bit of xml is a single attribute for this gbean so if you want to modify something via config.xml you'd need the entire xml snippet in config.xml.  At that point the ${} substitutions ought to work.

I don't recall anything like this in the standard geronimo plugins but we do something like this in the tck server to redefine the default environments for the builder so as to add some dependencies needed by all the test apps.

hope this relates to your question...
thanks
david jencks

On Tue, Jun 16, 2009 at 11:26 AM, Shawn Jiang <genspring@gmail.com> wrote:
Another question,  Seems config.xml does not support 

 <xml-attribute name="extendedJMXConnectorInfo">
             <ns:javabean xmlns:ns="http://geronimo.apache.org/xml/ns/deployment/javabean-1.0" class="org.apache.geronimo.farm.deployment.DeploymentExtendedJMXConnectorInfo">
                 <ns:property name="username">system</ns:property>
                 <ns:property name="password">manager</ns:property>
                 <ns:property name="protocol">rmi</ns:property>
                 <ns:property name="host">localhost</ns:property>
                 <ns:property name="port"> ${NamingPort + PortOffset}</ns:property>

                 <ns:property name="urlPath">JMXConnector</ns:property>
                 <ns:property name="local">true</ns:property>
             </ns:javabean>
         </xml-attribute>

style configuration.   I have to add a "port" attribute to BasicNodeInfo so that I can expose it to config.xml in pom.xml. 

Also, I agree that username and password should not be in config-substitutions.properties.  But I do think they should be exposed in config.xml so that the user can change them when he change the user/password of server.



On Mon, Jun 15, 2009 at 6:50 PM, Gianny Damour <gianny.damour@optusnet.com.au> wrote:
Hi Shawn,

username, password and host should not be in config-substitutions.properties.

port is the only candidate and should be set to ${NamingPort + PortOffset}

Thanks,
Gianny


On 15/06/2009, at 6:14 PM, Shawn Jiang wrote:


In  Gtrunk\plugins\clustering\farming\src\main\plan\plan.xml,  there are some  hardcodeed ser/pass/host/port string in it. I'm not sure if they should be something like ${PlanClusterNodeName} so that they can be set in server\config\config_substitution.properties.



<gbean name="NodeInfo" class="org.apache.geronimo.farm.config.BasicNodeInfo">
         <attribute name="name">${PlanClusterNodeName}</attribute>
         <xml-attribute name="extendedJMXConnectorInfo">
             <ns:javabean xmlns:ns="http://geronimo.apache.org/xml/ns/deployment/javabean-1.0" class="org.apache.geronimo.farm.deployment.DeploymentExtendedJMXConnectorInfo">
                 <ns:property name="username">system</ns:property>
                 <ns:property name="password">manager</ns:property>
                 <ns:property name="protocol">rmi</ns:property>
                 <ns:property name="host">localhost</ns:property>
                 <ns:property name="port">1099</ns:property>
                 <ns:property name="urlPath">JMXConnector</ns:property>
                 <ns:property name="local">true</ns:property>
             </ns:javabean>
         </xml-attribute>
     </gbean>


Can anyone give me any thoughts ?

--
Shawn




--
Shawn



--
Shawn