Yes, without moving this, an error will occur in the build process, which
says that the taglib version for pluto is not found.
Ivan
2009/6/25 David Jencks <david_jencks@yahoo.com>
> What is your reasoning for moving the import dependency? I was thinking
> that we should minimize the exposure to the pluto imports. I don't have a
> strong preference but wondered why you went to the trouble to move them.
> Was there a compilation problem?
>
> thanks
> david jencks
>
> On Jun 24, 2009, at 7:02 AM, xuhaihong@apache.org wrote:
>
> Author: xuhaihong
>> Date: Wed Jun 24 14:02:24 2009
>> New Revision: 788026
>>
>> URL: http://svn.apache.org/viewvc?rev=788026&view=rev
>> Log:
>> GERONIMO-4708 Move the import dependency to its parent
>>
>> Modified:
>> geronimo/server/trunk/plugins/activemq/activemq-portlets/pom.xml
>> geronimo/server/trunk/plugins/activemq/pom.xml
>> geronimo/server/trunk/plugins/debugviews/debugviews-portlets/pom.xml
>> geronimo/server/trunk/plugins/debugviews/pom.xml
>> geronimo/server/trunk/plugins/openejb/openejb-portlets/pom.xml
>> geronimo/server/trunk/plugins/openejb/pom.xml
>> geronimo/server/trunk/plugins/plancreator/plancreator-portlets/pom.xml
>> geronimo/server/trunk/plugins/plancreator/pom.xml
>> geronimo/server/trunk/plugins/system-database/pom.xml
>> geronimo/server/trunk/plugins/system-database/sysdb-portlets/pom.xml
>>
>> Modified: geronimo/server/trunk/plugins/activemq/activemq-portlets/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-portlets/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/activemq/activemq-portlets/pom.xml
>> (original)
>> +++ geronimo/server/trunk/plugins/activemq/activemq-portlets/pom.xml Wed
>> Jun 24 14:02:24 2009
>> @@ -21,19 +21,7 @@
>> <artifactId>activemq-portlets</artifactId>
>> <name>Geronimo Plugins, ActiveMQ v5 :: Portlets</name>
>> <packaging>war</packaging>
>> -
>> - <dependencyManagement>
>> - <dependencies>
>> - <dependency>
>> - <groupId>org.apache.geronimo.plugins</groupId>
>> - <artifactId>pluto</artifactId>
>> - <version>${version}</version>
>> - <type>pom</type>
>> - <scope>import</scope>
>> - </dependency>
>> -
>> - </dependencies>
>> - </dependencyManagement>
>> +
>> <dependencies>
>> <!-- for jspc maven plugin -->
>> <dependency>
>>
>> Modified: geronimo/server/trunk/plugins/activemq/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/activemq/pom.xml (original)
>> +++ geronimo/server/trunk/plugins/activemq/pom.xml Wed Jun 24 14:02:24
>> 2009
>> @@ -105,6 +105,14 @@
>> </exclusions>
>> </dependency>
>>
>> + <dependency>
>> + <groupId>org.apache.geronimo.plugins</groupId>
>> + <artifactId>pluto</artifactId>
>> + <version>${version}</version>
>> + <type>pom</type>
>> + <scope>import</scope>
>> + </dependency>
>> +
>> </dependencies>
>> </dependencyManagement>
>>
>>
>> Modified:
>> geronimo/server/trunk/plugins/debugviews/debugviews-portlets/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/debugviews/debugviews-portlets/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/debugviews/debugviews-portlets/pom.xml
>> (original)
>> +++ geronimo/server/trunk/plugins/debugviews/debugviews-portlets/pom.xml
>> Wed Jun 24 14:02:24 2009
>> @@ -32,19 +32,6 @@
>> <name>Geronimo Plugins, Debug Views :: Portlets</name>
>> <packaging>war</packaging>
>>
>> - <dependencyManagement>
>> - <dependencies>
>> - <dependency>
>> - <groupId>org.apache.geronimo.plugins</groupId>
>> - <artifactId>pluto</artifactId>
>> - <version>${version}</version>
>> - <type>pom</type>
>> - <scope>import</scope>
>> - </dependency>
>> -
>> - </dependencies>
>> - </dependencyManagement>
>> - <dependencies>
>> <!-- for jspc maven plugin -->
>> <dependency>
>> <groupId>org.apache.geronimo.framework</groupId>
>>
>> Modified: geronimo/server/trunk/plugins/debugviews/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/debugviews/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/debugviews/pom.xml (original)
>> +++ geronimo/server/trunk/plugins/debugviews/pom.xml Wed Jun 24 14:02:24
>> 2009
>> @@ -42,5 +42,19 @@
>> <module>debugviews-console-jetty</module>
>> </modules>
>>
>> + <dependencyManagement>
>> + <dependencies>
>> + <dependency>
>> + <groupId>org.apache.geronimo.plugins</groupId>
>> + <artifactId>pluto</artifactId>
>> + <version>${version}</version>
>> + <type>pom</type>
>> + <scope>import</scope>
>> + </dependency>
>> +
>> + </dependencies>
>> + </dependencyManagement>
>> + <dependencies>
>> +
>> </project>
>>
>>
>> Modified: geronimo/server/trunk/plugins/openejb/openejb-portlets/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/openejb/openejb-portlets/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/openejb/openejb-portlets/pom.xml
>> (original)
>> +++ geronimo/server/trunk/plugins/openejb/openejb-portlets/pom.xml Wed Jun
>> 24 14:02:24 2009
>> @@ -31,19 +31,6 @@
>> <artifactId>openejb-portlets</artifactId>
>> <name>Geronimo Plugins, OpenEJB :: Portlets</name>
>> <packaging>war</packaging>
>> -
>> - <dependencyManagement>
>> - <dependencies>
>> - <dependency>
>> - <groupId>org.apache.geronimo.plugins</groupId>
>> - <artifactId>pluto</artifactId>
>> - <version>${version}</version>
>> - <type>pom</type>
>> - <scope>import</scope>
>> - </dependency>
>> -
>> - </dependencies>
>> - </dependencyManagement>
>>
>> <dependencies>
>> <!-- for jspc maven plugin -->
>>
>> Modified: geronimo/server/trunk/plugins/openejb/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/openejb/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/openejb/pom.xml (original)
>> +++ geronimo/server/trunk/plugins/openejb/pom.xml Wed Jun 24 14:02:24 2009
>> @@ -50,4 +50,17 @@
>> <module>openejb-clustering-builder-wadi</module>
>> </modules>
>>
>> + <dependencyManagement>
>> + <dependencies>
>> + <dependency>
>> + <groupId>org.apache.geronimo.plugins</groupId>
>> + <artifactId>pluto</artifactId>
>> + <version>${version}</version>
>> + <type>pom</type>
>> + <scope>import</scope>
>> + </dependency>
>> +
>> + </dependencies>
>> + </dependencyManagement>
>> +
>> </project>
>>
>> Modified:
>> geronimo/server/trunk/plugins/plancreator/plancreator-portlets/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/plancreator/plancreator-portlets/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/plancreator/plancreator-portlets/pom.xml
>> (original)
>> +++ geronimo/server/trunk/plugins/plancreator/plancreator-portlets/pom.xml
>> Wed Jun 24 14:02:24 2009
>> @@ -32,19 +32,6 @@
>> <name>Geronimo Plugins, Plan Creator :: Portlets</name>
>> <packaging>war</packaging>
>>
>> - <dependencyManagement>
>> - <dependencies>
>> - <dependency>
>> - <groupId>org.apache.geronimo.plugins</groupId>
>> - <artifactId>pluto</artifactId>
>> - <version>${version}</version>
>> - <type>pom</type>
>> - <scope>import</scope>
>> - </dependency>
>> -
>> - </dependencies>
>> - </dependencyManagement>
>> -
>> <dependencies>
>> <!-- for jspc maven plugin -->
>> <dependency>
>>
>> Modified: geronimo/server/trunk/plugins/plancreator/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/plancreator/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/plancreator/pom.xml (original)
>> +++ geronimo/server/trunk/plugins/plancreator/pom.xml Wed Jun 24 14:02:24
>> 2009
>> @@ -42,5 +42,17 @@
>> <module>plancreator-console-tomcat</module>
>> </modules>
>>
>> + <dependencyManagement>
>> + <dependencies>
>> + <dependency>
>> + <groupId>org.apache.geronimo.plugins</groupId>
>> + <artifactId>pluto</artifactId>
>> + <version>${version}</version>
>> + <type>pom</type>
>> + <scope>import</scope>
>> + </dependency>
>> + </dependencies>
>> + </dependencyManagement>
>> +
>> </project>
>>
>>
>> Modified: geronimo/server/trunk/plugins/system-database/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/system-database/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/system-database/pom.xml (original)
>> +++ geronimo/server/trunk/plugins/system-database/pom.xml Wed Jun 24
>> 14:02:24 2009
>> @@ -311,7 +311,14 @@
>> </exclusion>
>> </exclusions>
>> </dependency>
>> -
>> +
>> + <dependency>
>> + <groupId>org.apache.geronimo.plugins</groupId>
>> + <artifactId>pluto</artifactId>
>> + <version>${version}</version>
>> + <type>pom</type>
>> + <scope>import</scope>
>> + </dependency>
>> </dependencies>
>> </dependencyManagement>
>> </project>
>>
>> Modified:
>> geronimo/server/trunk/plugins/system-database/sysdb-portlets/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/system-database/sysdb-portlets/pom.xml?rev=788026&r1=788025&r2=788026&view=diff
>>
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/system-database/sysdb-portlets/pom.xml
>> (original)
>> +++ geronimo/server/trunk/plugins/system-database/sysdb-portlets/pom.xml
>> Wed Jun 24 14:02:24 2009
>> @@ -31,19 +31,6 @@
>> <artifactId>sysdb-portlets</artifactId>
>> <name>Geronimo Plugins, System Database :: Portlets</name>
>> <packaging>war</packaging>
>> -
>> - <dependencyManagement>
>> - <dependencies>
>> - <dependency>
>> - <groupId>org.apache.geronimo.plugins</groupId>
>> - <artifactId>pluto</artifactId>
>> - <version>${version}</version>
>> - <type>pom</type>
>> - <scope>import</scope>
>> - </dependency>
>> -
>> - </dependencies>
>> - </dependencyManagement>
>>
>> <dependencies>
>> <!-- for jspc maven plugin -->
>>
>>
>>
--
Ivan
|