geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Nodet <gno...@gmail.com>
Subject Re: svn commit: r774794 - /geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/ReferenceRecipe.java
Date Thu, 14 May 2009 15:35:11 GMT
Where is that done ? The only reference to
ServiceReferenceAccessor#getServiceReference() comes from the
ReferenceRecipe which will not be used when using constructor
arguments or even when using something like;

  <bean ...>
     <property name="xxx">
        <reference interface="yyy" />
    </property>
  </bean>

Do I miss something ? I'll try to fix the integration tests which are
broken for some reason and add a test there, but any insight would be
nice.

2009/5/14 gawor <gawor@apache.org>:
> Author: gawor
> Date: Thu May 14 14:48:00 2009
> New Revision: 774794
>
> URL: http://svn.apache.org/viewvc?rev=774794&view=rev
> Log:
> fix the todo as ServiceReference conversion is supported for direct and indirect injections
>
> Modified:
>    geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/ReferenceRecipe.java
>
> Modified: geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/ReferenceRecipe.java
> URL: http://svn.apache.org/viewvc/geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/ReferenceRecipe.java?rev=774794&r1=774793&r2=774794&view=diff
> ==============================================================================
> --- geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/ReferenceRecipe.java
(original)
> +++ geronimo/sandbox/blueprint/blueprint-core/src/main/java/org/apache/geronimo/blueprint/context/ReferenceRecipe.java
Thu May 14 14:48:00 2009
> @@ -116,9 +116,7 @@
>                 Recipe recipe = (Recipe) object;
>                 object = recipe.create(expectedType, false);
>             } else if (isServiceReferenceInjection(object, expectedType)) {
> -                // TODO: I don't think this is sufficient as the reference injection
may be done by
> -                // TODO: having a direct dependency on the service and not go
through a <ref> element
> -                // TODO: the conversion has to be done by the conversion service
imho
> +                // TODO: this conversion might potentially be done via conversion
service
>                 object = ((ServiceReferenceAccessor) object).getServiceReference();
>             }
>         }
>
>
>



-- 
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Mime
View raw message