Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 20781 invoked from network); 23 Mar 2009 13:45:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Mar 2009 13:45:36 -0000 Received: (qmail 45263 invoked by uid 500); 23 Mar 2009 13:45:35 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 45177 invoked by uid 500); 23 Mar 2009 13:45:35 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 45169 invoked by uid 99); 23 Mar 2009 13:45:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2009 13:45:35 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of genspring@gmail.com designates 209.85.146.177 as permitted sender) Received: from [209.85.146.177] (HELO wa-out-1112.google.com) (209.85.146.177) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2009 13:45:27 +0000 Received: by wa-out-1112.google.com with SMTP id v27so1699331wah.3 for ; Mon, 23 Mar 2009 06:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=77osyUSeJ/BW1dPMTk51a2j1wdkptWcIIVYGHlgsJnA=; b=h9/6LEfdaCFJU4hs3V7CZTqhRw1qfGy0NWh8Wlhu+ZeT/IQlyAIPLUzusaBT/D4R6D z6h9I0B+9777P9q7PSzWBgN6dqkYWMGcQS+XkGEXTM+L/M6tvEY6EOkTfvVUBomxp/kg UjxAO0uRCwgDTOu2OhnVvnMusRVFkrZipRQwE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=NzX6/ub+roxNu7I8H7ScaDnT6HhGOXzpvQu2vEh2EfEUplWfNc2aisO5FPPGYxurHM WxTWnWjMmcDOHVT2FqZLZ+H1IBBlcU9phN3Apq/VHb5Pa6x9ARB4L0oDQ7HOxrGvJH20 jmfsSKtluLsyUiQJviKdE6zw2GRcj6BCd0ezc= MIME-Version: 1.0 Received: by 10.114.57.1 with SMTP id f1mr4804682waa.145.1237815905535; Mon, 23 Mar 2009 06:45:05 -0700 (PDT) In-Reply-To: <49C78CD5.3050104@earthlink.net> References: <49BFFD7E.8000206@earthlink.net> <45f744e40903171926x5f6e80c2xdc7dd0b253d82b67@mail.gmail.com> <49C06378.60200@earthlink.net> <49C3850C.5070908@earthlink.net> <49C78CD5.3050104@earthlink.net> Date: Mon, 23 Mar 2009 21:45:05 +0800 Message-ID: Subject: Re: Geronimo 2.1.4 code freeze From: Shawn Jiang To: dev@geronimo.apache.org Content-Type: multipart/alternative; boundary=0016364581c458c7920465c979c6 X-Virus-Checked: Checked by ClamAV on apache.org --0016364581c458c7920465c979c6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I agree that to change the doc is another solution. But all the connector created with console wizard will default be rar type. In this case, the user can't export the connector he/she just created. It looks quite strange. That's why I prefer to include the RAR type in the list instead of only CAR type. On Mon, Mar 23, 2009 at 9:21 PM, Joe Bohn wrote: > I think this requires a little more discussion. > > We seem to be flip-flopping on what should or should not be included in the > list of plugins to export. > > GERONIMO-4141 and the discussion around it was rather explicit that we > should only include cars in the list. I believe the discussion at that time > was that any component which might potentially be exported should specify > "car" as it's module type and hence it will appear in the list. > > If you specify a type of car instead of rar in the deployment plan for the > db pool it will also appear in the list of potential plugins to export. So, > perhaps the doc should be changed rather than the code (and also perhaps > change the dbpool wizard so that it includes type car rather than rar)? > > Basically, I think we need agreement before we push this change into 2.1.4. > > The change is minor and wouldn't cause a problem to integrate but I'd like > to verify that we have a consistent approach to plugins. > > Joe > > > Shawn Jiang wrote: > >> I really think GERONIMO-4492 < >> https://issues.apache.org/jira/browse/GERONIMO-4492>should be applied to >> 2.1.4. If we don't, the defect will break the published document here: >> http://cwiki.apache.org/GMOxDOC21/convert-your-current-applications-into-plugins.html >> >> On Fri, Mar 20, 2009 at 7:59 PM, Joe Bohn > joe.bohn@earthlink.net>> wrote: >> >> After a quick read of the JIRA and patch I agree ... I'll take a >> closer look and apply it if all still seems well. >> >> Thanks, >> Joe >> >> Shawn Jiang wrote: >> >> If possible, I think this jira should be integrated because it's >> easy to be reproduced and easy to be fixed. >> >> https://issues.apache.org/jira/browse/GERONIMO-4595 >> >> On Wed, Mar 18, 2009 at 10:59 AM, Joe Bohn >> >> >> >> wrote: >> >> Go ahead and integrate the fix. >> >> Regards, >> Joe >> >> >> Ivan wrote: >> >> If possible, >> >> I wish that GERONIMO-4529) Corba port 1050 is not >> released after >> stopping j2ee-corba-yoko configuration is included in >> 2.1.4. >> Thanks ! >> Ivan >> >> 2009/3/18 Joe Bohn > >> > > > >> >> > >>> >> >> > >> > I think we're at a point where we should freeze >> branches/2.1.4 in prep for a release. OpenEJB 3.0.1 is >> in the >> process of being released and the OpenJPA 1.2.1 vote should >> close tomorrow. Those were our two primary dependencies >> that we >> were waiting on. >> > >> > Please check with Jarek or me if you would like to >> integrate >> any additional changes into 2.1.4. We'll hopefully be >> able to >> produce a release candidate later this week. >> > >> > Thanks, >> > Joe >> >> >> >> -- >> Ivan >> >> >> >> >> >> -- Shawn >> >> >> >> >> >> -- >> Shawn >> > > -- Shawn --0016364581c458c7920465c979c6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I agree that to change the doc is another solution. =A0But=A0all the c= onnector created with console wizard will default be rar type. =A0In this c= ase, the user can't export the connector he/she just created. =A0It loo= ks quite strange. =A0 That's why I prefer to include the RAR type in th= e list instead of only CAR type. =A0

On Mon, Mar 23, 2009 at 9:21 PM, Joe Bo= hn <joe.bohn= @earthlink.net> wrote:
I think this requires a little more discussion.

We seem to be flip-flopping on what should or should not be included in the= list of plugins to export.

GERONIMO-4141 and the discussion around it was rather explicit that we shou= ld only include cars in the list. =A0I believe the discussion at that time = was that any component which might potentially be exported should specify &= quot;car" as it's module type and hence it will appear in the list= .

If you specify a type of car instead of rar in the deployment plan for the = db pool it will also appear in the list of potential plugins to export. =A0= So, perhaps the doc should be changed rather than the code (and also perhap= s change the dbpool wizard so that it includes type car rather than rar)?
Basically, I think we need agreement before we push this change into 2.1.4.=

The change is minor and wouldn't cause a problem to integrate but I'= ;d like to verify that we have a consistent approach to plugins.

Joe


Shawn Jiang wrote:
=A0I really think GERONIMO-4492 =A0<https://issues.apache.org/ji= ra/browse/GERONIMO-4492>should be applied to 2.1.4. If we don't,= the defect will break the published document here: http://cwiki.apache.org/GMOxDOC21/convert-your-current-ap= plications-into-plugins.html


On Fri, Mar 20, 2009 at 7:59 PM, Joe Bohn <joe.bohn@earthlink.net <mailto:joe.bohn@earthlink.ne= t>> wrote:

=A0 =A0After a quick read of the JIRA and patch I agree ... I'll take = a
=A0 =A0closer look and apply it if all still seems well.

=A0 =A0Thanks,
=A0 =A0Joe

=A0 =A0Shawn Jiang wrote:

=A0 =A0 =A0 =A0If possible, I think this jira should be integrated because= it's
=A0 =A0 =A0 =A0easy to be reproduced and easy to be fixed.

=A0 =A0 =A0 =A0 https://issues.apache.org/jira/browse/GERONIMO-4595=

=A0 =A0 =A0 =A0On Wed, Mar 18, 2009 at 10:59 AM, Joe Bohn
=A0 =A0 =A0 =A0<joe.bohn@earthlink.net <mailto:joe.bohn@earthlink.net>
=A0 =A0 =A0 =A0<mailto:joe.bohn@earthlink.net <mailto:joe.bohn@earthlink.net>>> =A0 =A0 =A0 =A0wrote:

=A0 =A0 =A0 =A0 =A0 Go ahead and integrate the fix.

=A0 =A0 =A0 =A0 =A0 Regards,
=A0 =A0 =A0 =A0 =A0 Joe


=A0 =A0 =A0 =A0 =A0 Ivan wrote:

=A0 =A0 =A0 =A0 =A0 =A0 =A0 If possible,

=A0 =A0 =A0 =A0 =A0 =A0 =A0 I wish that GERONIMO-4529) Corba port 1050 is = not
=A0 =A0 =A0 =A0released after
=A0 =A0 =A0 =A0 =A0 =A0 =A0 stopping j2ee-corba-yoko configuration =A0is i= ncluded in 2.1.4.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 Thanks !
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Ivan

=A0 =A0 =A0 =A0 =A0 =A0 =A0 2009/3/18 Joe Bohn <joe.bohn@earthlink.net
=A0 =A0 =A0 =A0<mailto:joe.bohn@earthlink.net>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 <mailto:joe.bohn@earthlink.net
=A0 =A0 =A0 =A0<mailto:joe.bohn@earthlink.net>> <mailto:joe.bohn@earthlink.net

=A0 =A0 =A0 =A0<mailto:joe.bohn@earthlink.net>

=A0 =A0 =A0 =A0 =A0 =A0 =A0 <mailto:joe.bohn@earthlink.net
=A0 =A0 =A0 =A0<mailto:joe.bohn@earthlink.net>>>>

=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0> I think we're at a point where we = should freeze
=A0 =A0 =A0 =A0 =A0 =A0 =A0 branches/2.1.4 in prep for a release. =A0OpenE= JB 3.0.1 is
=A0 =A0 =A0 =A0in the
=A0 =A0 =A0 =A0 =A0 =A0 =A0 process of being released and the OpenJPA 1.2.= 1 vote should
=A0 =A0 =A0 =A0 =A0 =A0 =A0 close tomorrow. =A0Those were our two primary = dependencies
=A0 =A0 =A0 =A0that we
=A0 =A0 =A0 =A0 =A0 =A0 =A0 were waiting on.
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0> Please check with Jarek or me if you w= ould like to
=A0 =A0 =A0 =A0integrate
=A0 =A0 =A0 =A0 =A0 =A0 =A0 any additional changes into 2.1.4. =A0We'l= l hopefully be
=A0 =A0 =A0 =A0able to
=A0 =A0 =A0 =A0 =A0 =A0 =A0 produce a release candidate later this week. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0>
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0> Thanks,
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0> Joe



=A0 =A0 =A0 =A0 =A0 =A0 =A0 --
=A0 =A0 =A0 =A0 =A0 =A0 =A0 Ivan





=A0 =A0 =A0 =A0-- =A0 =A0 =A0 =A0Shawn





--
Shawn




--
Shawn
--0016364581c458c7920465c979c6--