geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bohn (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (GERONIMO-4595) script error when clicking the update button in portlet console ---server---Server Logs -- Log Manager
Date Fri, 20 Mar 2009 17:08:51 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683939#action_12683939
] 

Joe Bohn edited comment on GERONIMO-4595 at 3/20/09 10:08 AM:
--------------------------------------------------------------

Ok, so it isn't quite so obvious of an error ... but we still might as well fix it since it's
small and it has been identified.  Thanks for catching it.

I'm going to check-in a modified version of your patch.  IIUC there is no need to query or
check for a non-existent logFile ... so instead I've updated it to check for the configFile.
 This also gets the reset function working again.

{noformat}
 function <portlet:namespace/>validateForm(){
     with(document.<portlet:namespace/>update){
-        if(trim(logFile.value).length == ""){
-            alert("Please input the log file name.");
-            logFile.value="";
-            logFile.focus();
+        if(trim(configFile.value).length == ""){
+            alert("Please input the configuration file name.");
+            configFile.value="";
+            configFile.focus();
             return false;
         }
-        if(trim(layoutPattern.value) == ""){
-            alert("Please input layout pattern.");
-            layoutPattern.value="";
-            layoutPattern.focus();
-            return false;
-        }
-        
     }
     return true;
 }
{noformat}


      was (Author: jbohn):
    Ok, so it isn't quite so obvious of an error ... but we still might as well fix it since
it's small and it has been identified.  Thanks for catching it.

I'm going to check-in a modified version of your patch.  IIUC there is no need to query or
check for a non-existent logFile ... so instead I've updated it to check for the configFile.
 This also gets the reset function working again.

 function <portlet:namespace/>validateForm(){
     with(document.<portlet:namespace/>update){
-        if(trim(logFile.value).length == ""){
-            alert("Please input the log file name.");
-            logFile.value="";
-            logFile.focus();
+        if(trim(configFile.value).length == ""){
+            alert("Please input the configuration file name.");
+            configFile.value="";
+            configFile.focus();
             return false;
         }
-        if(trim(layoutPattern.value) == ""){
-            alert("Please input layout pattern.");
-            layoutPattern.value="";
-            layoutPattern.focus();
-            return false;
-        }
-        
     }
     return true;
 }
  
> script error when clicking the update button in portlet console ---server---Server Logs
-- Log Manager 
> -------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4595
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4595
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 2.1.4, 2.1.5, 2.2
>         Environment: IE7 + windows XP + sun JDK 1.5
>            Reporter: Shawn Jiang
>            Assignee: Joe Bohn
>            Priority: Minor
>         Attachments: patch_script_error.patch
>
>
> reproduce steps:
> 1, Use IE to login to console.
> 2, Click the update button in portlet console --->  server  --->  Server Logs -->
 Log Manager 
> expected result:  no error
> actual result:   there's a script error " logFile is not defined"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message