Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 64171 invoked from network); 13 Jan 2009 15:30:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Jan 2009 15:30:46 -0000 Received: (qmail 80589 invoked by uid 500); 13 Jan 2009 15:30:44 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 80547 invoked by uid 500); 13 Jan 2009 15:30:44 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 80538 invoked by uid 99); 13 Jan 2009 15:30:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2009 07:30:44 -0800 X-ASF-Spam-Status: No, hits=2.4 required=10.0 tests=HTML_MESSAGE,SPF_PASS,WHOIS_MYPRIVREG X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of greensight@gmail.com designates 209.85.200.172 as permitted sender) Received: from [209.85.200.172] (HELO wf-out-1314.google.com) (209.85.200.172) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2009 15:30:35 +0000 Received: by wf-out-1314.google.com with SMTP id 28so54242wfa.25 for ; Tue, 13 Jan 2009 07:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type:references; bh=vEd+FoAB3te1IsK5k+ePXqB9wzvbwgwk/mUej7ML+Fg=; b=WH4hNlAsrgJduwrN7UHUCC9hzamLRvUx+dQDOJVOkqU5faunm9T5khZjsD7FcslyqD AEJ0rUxRrdEbjNhFX2Ypw2ome7vHXNSLnzHllV0LQOHOqR+oeYceFuFKiDrQtLgK/k7C uP2BUjlu4G8j3MeMM0g515blqphSv2DQlKbcE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:references; b=HFfq3wPKj+/XsOQn/VMa54ViFH/9rS1ReSXMpgRrpSoCC1fLEhyGMGGgd+PHqodFFJ 7Qi+LDfLmcPiFFSilBEvGz/LtqnWxyXEOZncwyE0ZxXCDxzk40U3ZU4nrgaYmoZWoj91 fdcqeIA85hE2pBaK36u5Z/JhvvAZnjHcR9TRQ= Received: by 10.142.89.13 with SMTP id m13mr12918308wfb.185.1231860613715; Tue, 13 Jan 2009 07:30:13 -0800 (PST) Received: by 10.143.12.4 with HTTP; Tue, 13 Jan 2009 07:30:13 -0800 (PST) Message-ID: <5e7fd1eb0901130730r6902056v9f1d1dd81d70bc93@mail.gmail.com> Date: Tue, 13 Jan 2009 23:30:13 +0800 From: "Jack Cai" To: dev@geronimo.apache.org Subject: Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_63959_25140209.1231860613701" References: <316493443.1231731899587.JavaMail.jira@brutus> <1811320804.1231859701753.JavaMail.jira@brutus> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_63959_25140209.1231860613701 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline It will. You can read the javadoc of ResourceBundle to see how it searches the bundles for a given locale. -Jack 2009/1/13 Gang Yin > Of course we can use both language and country parts, but now we only > provide property files like *.zh.properties rather than *.zh-CN.properties, > I'm not sure if locale like zh-CN will match *.zh.properties. I will test > it, and If getLanguage() is not necessary I will remove it. > > > On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) wrote: > >> >> [ >> https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663355#action_12663355] >> >> Jack Cai commented on GERONIMO-4507: >> ------------------------------------ >> >> I don't quite understand why only the language part of the locale is used >> ... >> >> > Admin console should honor the priority of user agent's language setting >> > ------------------------------------------------------------------------ >> > >> > Key: GERONIMO-4507 >> > URL: >> https://issues.apache.org/jira/browse/GERONIMO-4507 >> > Project: Geronimo >> > Issue Type: Improvement >> > Security Level: public(Regular issues) >> > Components: console >> > Affects Versions: 2.1.3, 2.2 >> > Environment: All >> > Reporter: Jack Cai >> > Assignee: Donald Woods >> > Priority: Minor >> > Fix For: 2.2 >> > >> > Attachments: locale-priority.patch, locale-priority_fix.patch >> > >> > >> > See discussion: >> http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >> > ------=_Part_63959_25140209.1231860613701 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline It will. You can read the javadoc of ResourceBundle to see how it searches the bundles for a given locale.

-Jack


2009/1/13 Gang Yin <yg020840@gmail.com>
Of course we can use both language and country parts, but now we only provide property files like *.zh.properties rather than *.zh-CN.properties, I'm not sure if locale like zh-CN will match *.zh.properties. I will test it, and If getLanguage() is not necessary I will remove it.


On Tue, Jan 13, 2009 at 11:15 PM, Jack Cai (JIRA) <jira@apache.org> wrote:

   [ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663355#action_12663355 ]

Jack Cai commented on GERONIMO-4507:
------------------------------------

I don't quite understand why only the language part of the locale is used ...

> Admin console should honor the priority of user agent's language setting
> ------------------------------------------------------------------------
>
>                 Key: GERONIMO-4507
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4507
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues)
>          Components: console
>    Affects Versions: 2.1.3, 2.2
>         Environment: All
>            Reporter: Jack Cai
>            Assignee: Donald Woods
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: locale-priority.patch, locale-priority_fix.patch
>
>
> See discussion: http://www.nabble.com/Geronimo-Console-tp21369352s134p21383628.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



------=_Part_63959_25140209.1231860613701--