geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Trygve Hardersen <try...@jotta.no>
Subject Re: [jira] Closed: (GERONIMO-4522) history dependencies.xml file should support property substitutions. Plan processing should use maven filtering, not velocity
Date Tue, 27 Jan 2009 14:15:38 GMT
Hi

I hit a problem today with our custom Geronimo assembly that I think is
related to this:

We have many MySQL DB pools, each represented as a Geronimo plugin. The
plan.xml file for these plugins is very simmilar, so I'm sharing a common
file between the plugins:

db-plugin/pom.xml -->

<plugins>
    <plugin>
        <groupId>org.apache.geronimo.buildsupport</groupId>
        <artifactId>car-maven-plugin</artifactId>
        <extensions>true</extensions>
        <configuration>
            <!-- We use a common plan template for DB pools -->
              <planFileName>mysql-pool-plan.xml</planFileName>
            <sourceDir>${project.parent.basedir}/src/main/plan</sourceDir>
        </configuration>
    </plugin>
</plugins>

db-plugin/src/main/plan/mysql-pool-plan.xml -->

<?xml version="1.0" encoding="UTF-8"?>
<!-- The master DB connection pool -->
<connector xmlns="
http://geronimo.apache.org/xml/ns/j2ee/connector-${geronimoSchemaVersion}<http://geronimo.apache.org/xml/ns/j2ee/connector-$%7BgeronimoSchemaVersion%7D>
">
    <!-- The DB pool -->
    <resourceadapter>
        <outbound-resourceadapter>
            <connection-definition>

<connectionfactory-interface>javax.sql.DataSource</connectionfactory-interface>
                <connectiondefinition-instance>
                    <name>${currentDBName}</name>
                    <config-property-setting
name="ServerName">${currentDBHost}</config-property-setting>
                    <config-property-setting
name="PortNumber">${currentDBPort}</config-property-setting>
                    <config-property-setting
name="DatabaseName">${currentDBSchema}</config-property-setting>
                    <config-property-setting
name="UserName">${currentDBUser}</config-property-setting>
                    <config-property-setting
name="Password">${currentDBPass}</config-property-setting>
                    <connectionmanager>
                        <local-transaction/>
                        <single-pool>
                            <max-size>${currentDBMaxPoolSize}</max-size>
                            <min-size>${currentDBMinPoolSize}</min-size>

<blocking-timeout-milliseconds>${currentDBBlockTimeout}</blocking-timeout-milliseconds>

<idle-timeout-minutes>${currentDBIdleTimeout}</idle-timeout-minutes>
                            <match-one/>
                        </single-pool>
                    </connectionmanager>
                </connectiondefinition-instance>
            </connection-definition>
        </outbound-resourceadapter>
    </resourceadapter>
</connector>

db-plugin/db-001/pom.xml -->
....
<properties>
    <currentDBHost>db-001</currentDBHost>
    <currentDBName>db/shard-001</currentDBName>
    <currentDBSchema>jdb_shard_001</currentDBSchema>
</properties>
...
<build>
    <plugins>
        <plugin>
            <groupId>org.apache.geronimo.buildsupport</groupId>
            <artifactId>car-maven-plugin</artifactId>
            <configuration>
                <deploymentConfigs>

<!--<deploymentConfig>${gbeanDeployer}</deploymentConfig>-->

<deploymentConfig>${connectorDeployer}</deploymentConfig>
                </deploymentConfigs>
                <category>${productName}</category>
                   <module>
                    <groupId>org.tranql</groupId>
                    <artifactId>tranql-connector-mysql-local</artifactId>
                    <type>rar</type>
                   </module>
            </configuration>
        </plugin>
    </plugins>
</build>
...

The build still works, but the DB plugins are not included in the final
/var/config/config.xml file, so they are not started with the server. If I
create a plan.xml file in src/main/plan for each of the DB plugins
everything works fine.

Is "my way" of doing it not supported any longer, or is this a bug with
Geronimo?

Many thanks for your help!

Trygve

On Mon, Jan 26, 2009 at 9:35 AM, David Jencks (JIRA) <jira@apache.org>wrote:

>
>     [
> https://issues.apache.org/jira/browse/GERONIMO-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> David Jencks closed GERONIMO-4522.
> ----------------------------------
>
>    Resolution: Fixed
>
> Implemented rev 737650.
>
> To build g. with ee6 bits first build the jetty7 plugins from
> sandbox/djencks then do the main build with
>
> mvn clean install -Pee6,default
>
>
>
> > history dependencies.xml file should support property substitutions.
>  Plan processing should use maven filtering, not velocity
> >
> ------------------------------------------------------------------------------------------------------------------------------
> >
> >                 Key: GERONIMO-4522
> >                 URL: https://issues.apache.org/jira/browse/GERONIMO-4522
> >             Project: Geronimo
> >          Issue Type: Bug
> >      Security Level: public(Regular issues)
> >          Components: car-maven-plugin
> >    Affects Versions: 2.2
> >            Reporter: David Jencks
> >            Assignee: David Jencks
> >             Fix For: 2.2
> >
> >
> > In order to support easier switching between ee5 and ee6 builds we need
> to be able to use properties in the dependencies.xml files.  In addition the
> plan processing can remove a todo by using maven filtering rather than
> velocity.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Mime
View raw message