[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661679#action_12661679
]
B.J. Reed commented on GERONIMODEVTOOLS-547:
--------------------------------------------
Sorry Delos, but I'm still not getting a pluginInstaller from the following line:
pluginInstaller = kernel.getGBean(PluginInstallerGBean.class);
If I change the serverChanged method to catch a Throwable instead of an Exception, I still
get the above error.
The PluginManager does come up (Custom Server Assembly does not), but after going through
a few pages of it, I get a null pointer caused by pluginInstaller being null. Did you have
to update the manifest.mf or plugin.xml to get it to work?
> code cleanup on Server Plugin Manager
> -------------------------------------
>
> Key: GERONIMODEVTOOLS-547
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
> Project: Geronimo-Devtools
> Issue Type: Sub-task
> Components: eclipse-plugin
> Affects Versions: 2.2.0, 2.1.4
> Reporter: B.J. Reed
> Assignee: B.J. Reed
> Priority: Minor
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 547.patch, 547_updated.patch
>
>
> From the initial version of the Server Plugin Manager, there are several things that
can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels (org.apache.geronimo.jee.plugin).
When I tried to use the .jar file, I kept get exceptions that ObjectFactory could not be
found. As it is now, the org.apache.geronimo.jee.plugin classes are exact duplicates of what
is in the geronimo-system.jar file
> 2. GeronimoServerPluginManager.java should use PluginInstallerGbean. This will cut down
on a lot of methods that were duplicated into this class.
> 3. Other methods in GeronimoServerPluginManager.java can probably make other calls to
the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|