geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Delos Dai (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMODEVTOOLS-547) code cleanup on Server Plugin Manager
Date Fri, 09 Jan 2009 15:16:59 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662393#action_12662393
] 

Delos Dai commented on GERONIMODEVTOOLS-547:
--------------------------------------------

Oh, I find pluginInstaller should be created with PluginInstaller instead of PluginInstallGbean,
so I attach a new patch "547_updated2.patch".

This time, although I didn't find the exception you said, there are still some other exception
when I click "next" in last step. The wizard said plugin saved successfully, but several exceptions
were thrown. More details are in the "exception.txt".  Without 547_updated2.patch, these exception
still exist.

> code cleanup on Server Plugin Manager
> -------------------------------------
>
>                 Key: GERONIMODEVTOOLS-547
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.2.0, 2.1.4
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.2.0, 2.1.4
>
>         Attachments: 547.patch, 547_updated.patch, 547_updated2.patch
>
>
> From the initial version of the Server Plugin Manager, there are several things that
can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels (org.apache.geronimo.jee.plugin).
 When I tried to use the .jar file, I kept get exceptions that ObjectFactory could not be
found.  As it is now, the org.apache.geronimo.jee.plugin classes are exact duplicates of what
is in the geronimo-system.jar file
> 2. GeronimoServerPluginManager.java should use PluginInstallerGbean.  This will cut down
on a lot of methods that were duplicated into this class.
> 3. Other methods in GeronimoServerPluginManager.java can probably make other calls to
the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message