geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "B.J. Reed (JIRA)" <>
Subject [jira] Commented: (GERONIMODEVTOOLS-547) code cleanup on Server Plugin Manager
Date Tue, 06 Jan 2009 15:30:44 GMT


B.J. Reed commented on GERONIMODEVTOOLS-547:

Hi Delos, I applied your 547 patch to my latest GEP trunk and tried to use it with the 2.2
snapshot server.  To start with, I was getting a NullPointerException in the ServerPluginManager
constructor because the server variable hadn't been set yet.  So I moved the bulk of the constructor
to the serverChanged method.  Now I get the following stack trace:

java.lang.IllegalArgumentException: Cannot find matching method/constructor
	at org.apache.geronimo.system.plugin.PluginInstallerGBean$$EnhancerByCGLIB$$8fe213ef$$FastClassByCGLIB$$df601166.newInstance(<generated>)
	at net.sf.cglib.reflect.FastClass.newInstance(
	at org.apache.geronimo.kernel.basic.BasicProxyManager$ManagedProxyFactory.createProxy(
	at org.apache.geronimo.kernel.basic.BasicProxyManager.createProxy(
	at org.apache.geronimo.system.jmx.KernelDelegate.getGBean(
	at org.eclipse.ui.internal.PluginAction.refreshEnablement(
	at org.eclipse.ui.internal.PluginAction.createDelegate(
	at org.eclipse.ui.internal.PluginAction.runWithEvent(
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(
	at org.eclipse.jface.action.ActionContributionItem.access$2(
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(
	at org.eclipse.swt.widgets.EventTable.sendEvent(
	at org.eclipse.swt.widgets.Widget.sendEvent(
	at org.eclipse.swt.widgets.Display.runDeferredEvents(
	at org.eclipse.swt.widgets.Display.readAndDispatch(
	at org.eclipse.ui.internal.Workbench.runEventLoop(
	at org.eclipse.ui.internal.Workbench.runUI(
	at org.eclipse.ui.internal.Workbench.access$4(
	at org.eclipse.ui.internal.Workbench$
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(
	at org.eclipse.equinox.launcher.Main.basicRun(
	at org.eclipse.equinox.launcher.Main.main(

and the pluginInstaller variable remains null so it can't be used later (like in the getPluginMetadata
method).  Can you take another look at this?


> code cleanup on Server Plugin Manager
> -------------------------------------
>                 Key: GERONIMODEVTOOLS-547
>                 URL:
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.2.0, 2.1.4
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.2.0, 2.1.4
>         Attachments: 547.patch
> From the initial version of the Server Plugin Manager, there are several things that
can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels (org.apache.geronimo.jee.plugin).
 When I tried to use the .jar file, I kept get exceptions that ObjectFactory could not be
found.  As it is now, the org.apache.geronimo.jee.plugin classes are exact duplicates of what
is in the geronimo-system.jar file
> 2. should use PluginInstallerGbean.  This will cut down
on a lot of methods that were duplicated into this class.
> 3. Other methods in can probably make other calls to
the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message