geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "B.J. Reed (JIRA)" <>
Subject [jira] Commented: (GERONIMODEVTOOLS-450) Modifications to JAXB classes for DWR in PlanCreator
Date Tue, 13 Jan 2009 15:07:00 GMT


B.J. Reed commented on GERONIMODEVTOOLS-450:

I've looked at this patch and I have to put a -1 on it.

According to the comments in the code and from what I've seen, the getXXX methods for Lists
of Object are "accessor method returns a reference to the live list, not a snapshot. Therefore
any modification you make to the returned list will be present inside the JAXB object.  This
is why there is not a <CODE>set</CODE> method for the property."

This patch just adds set methods which aren't needed and could be potentially dangerous since
a set would replace any data that may already be present in a List of objects.

I will leave the JIRA open for a while to allow for any discussion to challenge the original

> Modifications to JAXB classes for DWR in PlanCreator
> ----------------------------------------------------
>                 Key: GERONIMODEVTOOLS-450
>                 URL:
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.1.2
>            Reporter: Shrey Banga
>            Assignee: Shiva Kumar H R
>             Fix For: 2.2.0
>         Attachments: GEP_JAXB_1.patch
> I've attached a patch which makes some modifications to JAXB classes in GEP in order
to support their use with DWR in PlanCreator.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message