Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <989075196.1228318424396.JavaMail.jira@brutus>
Date: Wed, 3 Dec 2008 07:33:44 -0800 (PST)
From: "Jarek Gawor (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Resolved: (GERONIMO-4441) The assignment to variable
 "handler" has no effect in ConstantLoginModule.java
In-Reply-To: <653784030.1228298504430.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/GERONIMO-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMO-4441.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2
                   2.1.4
         Assignee: Jarek Gawor

Patch committed to trunk (revision 722931) and branches/2.1 (revision 722932). Thanks!


> The assignment to variable "handler" has no effect in ConstantLoginModule.java
> ------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4441
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4441
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.1.3, 2.1.4, 2.2
>            Reporter: Shawn Jiang
>            Assignee: Jarek Gawor
>             Fix For: 2.1.4, 2.2
>
>         Attachments: GERONIMO-4441.patch
>
>
> Seems it's a typo bug in  https://svn.apache.org/repos/asf/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/ConstantLoginModule.java
>    /**
>      * Save the userName and groupNames settings for use during commit()
>      */
>     public void initialize(Subject subject, CallbackHandler callbackHandler,
>             Map sharedState, Map options) {
>         this.subject = subject;
>         this.handler = handler;
>         
>         this.userName = (String)options.get(USER_NAME);
>         this.groupNames = (String)options.get(GROUP_NAMES);
>     }
> "  this.handler = handler;"  should be  " this.handler = callbackHandler;"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.