Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 81352 invoked from network); 2 Dec 2008 14:59:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Dec 2008 14:59:20 -0000 Received: (qmail 66332 invoked by uid 500); 2 Dec 2008 14:59:31 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 66280 invoked by uid 500); 2 Dec 2008 14:59:30 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 66269 invoked by uid 99); 2 Dec 2008 14:59:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Dec 2008 06:59:30 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [209.86.89.69] (HELO elasmtp-mealy.atl.sa.earthlink.net) (209.86.89.69) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Dec 2008 14:58:03 +0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=dk20050327; d=earthlink.net; b=E4jpAoZIKALre1An8fwIpgh+SuQyqGMHVXjHHGSHrt2bZoVs13x6M857dOIyx4TU; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-ELNK-Trace:X-Originating-IP; Received: from [129.33.49.251] (helo=dyn9-37-243-139.raleigh.ibm.com) by elasmtp-mealy.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1L7Wha-0008Bm-QU for dev@geronimo.apache.org; Tue, 02 Dec 2008 09:58:14 -0500 Message-ID: <49354CED.8060609@earthlink.net> Date: Tue, 02 Dec 2008 09:57:49 -0500 From: Joe Bohn User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105) MIME-Version: 1.0 To: dev@geronimo.apache.org Subject: Re: GERONIMO-4229 References: <5eb405c70812011433x1b3d9a47i5d5e7fd3d676fac2@mail.gmail.com> <49353878.6080806@apache.org> In-Reply-To: <49353878.6080806@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: c408501814fc19611aa676d7e74259b7b3291a7d08dfec79397fb7f37082d56dcfe2112bb5cec2e8350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-Originating-IP: 129.33.49.251 X-Virus-Checked: Checked by ClamAV on apache.org I agree Joe Donald Woods wrote: > If it is no longer used, then #1 sounds like the right approach. > > > -Donald > > > Jarek Gawor wrote: >> Hi, >> >> I was looking at GERONIMO-4229 today (please see the bug and my >> comments for details). There is a remaining issue with the >> GERONIMO_BASE property and what it does. The Java system property that >> it sets is not used anywhere in the code and therefore that property >> is useless. I have a couple of ideas what we can do with it or how to >> fix it: >> >> 1) Totally get rid off GERONIMO_BASE in the shell scripts. It doesn't >> do anything right now anyway and it just confuses people. People that >> want to use multiple server instances will need to pass >> "org.apache.geronimo.server.dir" or "org.apache.geronimo.server.name" >> property using the GERONIMO_OPTS env. property (as it is documented >> today). >> >> or >> >> 2) Keep GERONIMO_BASE but only pass "org.apache.geronimo.server.dir" >> property (to the java process) if the user has set the GERONIMO_BASE >> env. property explicitly. That is, do not set GERONIMO_BASE property >> automatically within the script as it is done now. If it would be >> automatically set, the "org.apache.geronimo.server.name" property >> (passed via GERONIMO_OPTS) would always be ignored. >> >> Thoughts? >> >> Jarek >> >