Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <1203648880.1229096804400.JavaMail.jira@brutus>
Date: Fri, 12 Dec 2008 07:46:44 -0800 (PST)
From: "B.J. Reed (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMODEVTOOLS-547) code cleanup on Server
 Plugin Manager
In-Reply-To: <1990151380.1228512226195.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656045#action_12656045 ] 

B.J. Reed commented on GERONIMODEVTOOLS-547:
--------------------------------------------

Item #1 has been fixed with r726047 in trunk and r726056 in 2.1.4.
Thanks to Tim McConnell for figuring out what was missing in the manifest files to get this to work properly.

> code cleanup on Server Plugin Manager
> -------------------------------------
>
>                 Key: GERONIMODEVTOOLS-547
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-547
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.2.0, 2.1.4
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.2.0, 2.1.4
>
>
> From the initial version of the Server Plugin Manager, there are several things that can be streamlined.
> 1. use geronimo-system.jar file instead of the jaxbmodels (org.apache.geronimo.jee.plugin).  When I tried to use the .jar file, I kept get exceptions that ObjectFactory could not be found.  As it is now, the org.apache.geronimo.jee.plugin classes are exact duplicates of what is in the geronimo-system.jar file
> 2. GeronimoServerPluginManager.java should use PluginInstallerGbean.  This will cut down on a lot of methods that were duplicated into this class.
> 3. Other methods in GeronimoServerPluginManager.java can probably make other calls to the jar files that we already are bringing into the GEP.
> All of this will make the code much slimmer and re-use a lot of good code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.