geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Delos Dai (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMODEVTOOLS-532) Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)
Date Tue, 30 Dec 2008 08:58:44 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659776#action_12659776
] 

Delos Dai commented on GERONIMODEVTOOLS-532:
--------------------------------------------

In my opinion,it's better to add "publishing timeout" together with "publishing interval"
in "publishing" section. However, "publishing" section is rendered by class OverviewEditorPart
in org.eclipse.wst.server.ui,  currently no extension point available to update this section.
That means,  "publishing" section is a built-in section of overview page for server properites.

So here are two option for this:
1) With extension point "org.eclipse.wst.server.ui.editorPageSections", a separated section
including  "publishing timeout" can be created and added into "Overview" page, just like "VM
args" section and "Ports" section. In this way, the   "publishing timeout" will be separated
from "publishing" section.

2) Override the createPublishsection() in "OverviewEditorPart", which is used to render "publishing"
section. In this way, "publishing timeout" can be added into the built-in "publishing" section.
How to override? Now, "OverviewEditorPart" implement the overview page by contributing to
extension point "org.eclipse.wst.server.ui.editorPages". The key to this method is we have
to use the same page id as "OverviewEditorPart" when declaring our extension. Our extension
can inherit "OverviewEditorPart" and override the method createPublishsection()  of it. 

I have implemented option 2 and attach the patch. Hope someone can help to review it. 

Any comments?

Thanks!

> Surface the publish timeout time in the server properties tab like all the other publishing
attributes (e.g., publishing interval)
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-532
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
>             Project: Geronimo-Devtools
>          Issue Type: Bug
>          Components: eclipse-plugin
>    Affects Versions: 2.2.0, 2.1.4
>            Reporter: Tim McConnell
>            Assignee: Tim McConnell
>             Fix For: 2.2.0, 2.1.4
>
>         Attachments: 532.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message