Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: domain of jason.dillon@gmail.com
 designates 209.85.142.188 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:from:to:in-reply-to:content-type
         :content-transfer-encoding:mime-version:subject:date:references
         :x-mailer;
        b=cnEC3/anfcQO/7thGhdEyqtidU++6iglzf0dfgOdU7O/p8z+jK1giPm/AET5GZbm+H
         qy8wWHFvsx9eFyiJRUlQBe0wEe14+/Can55tq0R41IZNF4WK7vbccupNA388OesY5xjR
         uFmrbEWIN9Z0YfqMjlCdO5zDSgXJC0hRX//T8=
Message-Id: <CABDE4ED-1F2C-4B9F-8F4E-C7C8EE857D8C@gmail.com>
From: Jason Dillon <jason.dillon@gmail.com>
To: dev@geronimo.apache.org
In-Reply-To: <5eb405c70811070742v51f0edcfkbacb775a6c803460@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v929.2)
Subject: Re: svn commit: r712164 -
 /geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh
Date: Fri, 7 Nov 2008 22:47:47 +0700
References: <20081107153548.A876C238895D@eris.apache.org>
 <5eb405c70811070742v51f0edcfkbacb775a6c803460@mail.gmail.com>

Damn these scripts, I really think we should do away with them and use  
gshell.  Lets *document* the non-gshell ways to java -jar bin/server/ 
jar ..etc... but only ship the gshell commands.

--jason


On Nov 7, 2008, at 10:42 PM, Jarek Gawor wrote:

> Donald,
>
> I'm pretty sure this change will break the script if there is no
> jpa.jar in the bin directory.
>
> Jarek
>
> On Fri, Nov 7, 2008 at 10:35 AM,  <dwoods@apache.org> wrote:
>> Author: dwoods
>> Date: Fri Nov  7 07:35:24 2008
>> New Revision: 712164
>>
>> URL: http://svn.apache.org/viewvc?rev=712164&view=rev
>> Log:
>> GERONIMO-4389 Can't start server via geronimo.sh when install path  
>> contains a space.  Thanks to Jun Jie Cai (Jack) for the patch.
>>
>> Modified:
>>   geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/ 
>> underlay/contents/bin/geronimo.sh
>>
>> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate/src/ 
>> main/underlay/contents/bin/geronimo.sh
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh?rev=712164&r1=712163&r2=712164&view=diff
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/ 
>> underlay/contents/bin/geronimo.sh (original)
>> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/ 
>> underlay/contents/bin/geronimo.sh Fri Nov  7 07:35:24 2008
>> @@ -314,7 +314,7 @@
>> elif [ "$1" = "run" ]; then
>>  shift
>>  exec "$_RUNJAVA" $JAVA_OPTS $GERONIMO_OPTS \
>> -    $JAVA_AGENT_OPTS \
>> +    "$JAVA_AGENT_OPTS" \
>>    -Dorg.apache.geronimo.base.dir="$GERONIMO_BASE" \
>>    -Djava.endorsed.dirs="$ENDORSED_DIRS" \
>>    -Djava.ext.dirs="$EXT_DIRS" \
>> @@ -325,7 +325,7 @@
>>  shift
>>  touch "$GERONIMO_OUT"
>>  $START_OS_CMD "$_RUNJAVA" $JAVA_OPTS $GERONIMO_OPTS \
>> -    $JAVA_AGENT_OPTS \
>> +    "$JAVA_AGENT_OPTS" \
>>    -Dorg.apache.geronimo.base.dir="$GERONIMO_BASE" \
>>    -Djava.endorsed.dirs="$ENDORSED_DIRS" \
>>    -Djava.ext.dirs="$EXT_DIRS" \
>>
>>
>>