Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <704105289.1226045204564.JavaMail.jira@brutus>
Date: Fri, 7 Nov 2008 00:06:44 -0800 (PST)
From: "Jack Cai (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-4395) EmployeeDatasource and
 jdbc/EmployeeDatasource create the same files under
 $geronimo_install_dir/repository/console/dbpool directory
In-Reply-To: <506013392.1225947704253.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645712#action_12645712 ] 

Jack Cai commented on GERONIMO-4395:
------------------------------------

OK, so this is really the artifact ID instead of the datasource name. The new proposal here looks good to me.

2008/11/7 Ivan <xhhsld@gmail.com>

    Yes, a random artifact id may be less readable.
    But giving an error message may make the uesr feel confusion, actually, the database pool name is OK, it is different from any existing one, but the deployment failure is caused by that an unique artifact id is needed.
    I have another suggestion, after the user inputs the db pool name, and on the second wizard page, show the user what the artifact id will be used. The default artifact id would be replace all the slash in the dbpool name with an underscore.
    For example, if the db pool name is jdbc/TestDB, the default artifact id would be jdbc_TestDB, we will check that whether the default artifact id has been used, if it does, we generate a new artifact id, like jdbc_TestDB_1,  or we just use the default one, and show it on the page, so that the user has the opportunity to change it.
    Thanks for any comment !

> EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-4395
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4395
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: databases
>    Affects Versions: 2.1.3
>         Environment: Any platform
>            Reporter: viola.lu
>            Priority: Minor
>         Attachments: Geronimo-4395.patch
>
>
> Steps:
> 1.Login geronimo, go to database pool, create a "EmployeeDatasource" datasource with any db type.
> 2.create another "jdbc/EmployeeDatasource" datasource with any db type. But some read error display that
> EmployeeDatasource has existed in database pool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.