geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan <xhh...@gmail.com>
Subject Re: [jira] Commented: (GERONIMO-4395) EmployeeDatasource and jdbc/EmployeeDatasource create the same files under $geronimo_install_dir/repository/console/dbpool directory
Date Fri, 07 Nov 2008 07:55:09 GMT
Yes, a random artifact id may be less readable.But giving an error message
may make the uesr feel confusion, actually, the database pool name is OK, it
is different from any existing one, but the deployment failure is caused by
that an unique artifact id is needed.
I have another suggestion, after the user inputs the db pool name, and on
the second wizard page, show the user what the artifact id will be used. The
default artifact id would be replace all the slash in the dbpool name with
an underscore.
For example, if the db pool name is jdbc/TestDB, the default artifact id
would be jdbc_TestDB, we will check that whether the default artifact id has
been used, if it does, we generate a new artifact id, like jdbc_TestDB_1,
 or we just use the default one, and show it on the page, so that the user
has the opportunity to change it.
Thanks for any comment !


2008/11/6 Lin Sun (JIRA) <jira@apache.org>

>
>    [
> https://issues.apache.org/jira/browse/GERONIMO-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645486#action_12645486]
>
> Lin Sun commented on GERONIMO-4395:
> -----------------------------------
>
> I think I like the current impl better.   Having a random datasource name
> generated can be a big usability issue as this name would be needed to be
> referred in the resource ref in geronimo plans.
>
> Also, I think this is a very rare case.   Can you submit a patch to improve
> the error message?
>
> Lin
>
> > EmployeeDatasource and jdbc/EmployeeDatasource create the same files
> under $geronimo_install_dir/repository/console/dbpool directory
> >
> ------------------------------------------------------------------------------------------------------------------------------------
> >
> >                 Key: GERONIMO-4395
> >                 URL: https://issues.apache.org/jira/browse/GERONIMO-4395
> >             Project: Geronimo
> >          Issue Type: Bug
> >      Security Level: public(Regular issues)
> >          Components: databases
> >    Affects Versions: 2.1.3
> >         Environment: Any platform
> >            Reporter: viola.lu
> >            Priority: Minor
> >         Attachments: Geronimo-4395.patch
> >
> >
> > Steps:
> > 1.Login geronimo, go to database pool, create a "EmployeeDatasource"
> datasource with any db type.
> > 2.create another "jdbc/EmployeeDatasource" datasource with any db type.
> But some read error display that
> > EmployeeDatasource has existed in database pool.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


-- 
Ivan

Mime
View raw message