[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651220#action_12651220
]
Delos Dai commented on GERONIMODEVTOOLS-536:
--------------------------------------------
I found this extension declare in plugin.xml of org.apache.geronimo.st.core
<extension point="org.eclipse.wst.server.core.launchableAdapters">
<launchableAdapter
class="org.apache.geronimo.st.core.GeronimoLaunchableAdapterDelegate"
id="org.eclipse.jst.server.generic.web"/>
</extension>
In fact, the server adapter id should be unique.The id "org.eclipse.jst.server.generic.web"
has been used by a built-in generic server adapter of WTP. With the same id, it's not sure
which adapter is got by WTP. So sometimes if generic server adapter is got by WTP while a
browser needs to be launched, no module is bound with generic server adapter. It's the reason
why an NullPointException is thrown here.
I think we can give an unique id here.Maybe we can change the id into "org.eclipse.jst.server.geronimo.web".
I have verified this change locally.
Attachment is the patch for this defect.Could anyone help to review it?
Thanks a lot!
> Fail to launch browser when run a dynamic web application on server via GEP
> ---------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-536
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-536
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Environment: OS:Windows
> Reporter: viola.lu
> Assignee: Tim McConnell
> Priority: Minor
>
> Steps:
> 1.Open a clean eclipse, and then install GEP, define a server
> 2.Create a dynamic web application, and right-click "run on server"
> 3.No browser popups, and you will see error"Error opening browser" on "Error log" tab
at the bottom of eclipse.
> Error in elicpse:
> java.lang.NullPointerException
> at org.eclipse.wst.server.ui.internal.WebLaunchableClient.launch(WebLaunchableClient.java:39)
> at org.eclipse.wst.server.core.internal.Client.launch(Client.java:114)
> at org.eclipse.wst.server.ui.internal.LaunchClientJob$1.run(LaunchClientJob.java:79)
> at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:133)
> at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3800)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3425)
> at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2382)
> at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2346)
> at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2198)
> at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493)
> at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
> at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488)
> at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
> at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:386)
> at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> at java.lang.reflect.Method.invoke(Unknown Source)
> at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
> at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
> at org.eclipse.equinox.launcher.Main.run(Main.java:1236)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|