Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 90736 invoked from network); 3 Oct 2008 23:56:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Oct 2008 23:56:46 -0000 Received: (qmail 98774 invoked by uid 500); 3 Oct 2008 23:56:34 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 98726 invoked by uid 500); 3 Oct 2008 23:56:34 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 98715 invoked by uid 99); 3 Oct 2008 23:56:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2008 16:56:34 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2008 23:55:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 45C69234C20F for ; Fri, 3 Oct 2008 16:55:44 -0700 (PDT) Message-ID: <1167000359.1223078144278.JavaMail.jira@brutus> Date: Fri, 3 Oct 2008 16:55:44 -0700 (PDT) From: "Ted Kirby (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMODEVTOOLS-522) Feature.properties has a trailing backslash in it In-Reply-To: <968027262.1223058284238.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636776#action_12636776 ] Ted Kirby commented on GERONIMODEVTOOLS-522: -------------------------------------------- Thanks for bug report. I fixed it in trunk with rev 701571. We would like to work better in p2, and have had some issues with it. I don't know if we will do a 2.1.4. Currently trunk is targeted to 2.2. I wonder if we could or should fix this in 2.1.3 and put new artifacts on our eclipse plugin update site? > Feature.properties has a trailing backslash in it > ------------------------------------------------- > > Key: GERONIMODEVTOOLS-522 > URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-522 > Project: Geronimo-Devtools > Issue Type: Bug > Components: eclipse-plugin > Affects Versions: 2.1.3 > Reporter: Charles Overbeck > Assignee: Tim McConnell > > The feature.properties on the update site bundled with org.apache.geronimo.v21.feature_2.1.3.jar has a trailing backslash in it. The last two lines of the file are this: > trial in any resulting litigation. \n\ > \n\ > Note the trailing slash at the end of the second line; no characters follow it. This may not sound like a terrible bug on its own, but because that content ends up getting expanded inside the feature.xml, I think it escapes the next character in the feature.xml, which in this case is the "<" which closes a tag. This leads to an incorrectly generated content.xml file if you are generating an update site using Eclipse's P2 metadata generator, and you have the Geronimo feature present when you are doing the metadata generation. I don't know if it has any other side-effects. > In any case, that's why I'm proposing a priority of Major for this seeming trivial bug. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.