I didn't really want to expose setLocation in Command, hence the
reason why it was coded like that.
--jason
On Oct 16, 2008, at 1:04 AM, gnodet@apache.org wrote:
> Author: gnodet
> Date: Wed Oct 15 11:04:24 2008
> New Revision: 704975
>
> URL: http://svn.apache.org/viewvc?rev=704975&view=rev
> Log:
> Remove an ugly cast by adding the setLocation method to the Command
> interface
>
> Modified:
> geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/
> geronimo/gshell/command/Command.java
> geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/
> java/org/apache/geronimo/gshell/wisdom/registry/
> CommandRegistryImpl.java
>
> Modified: geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/
> geronimo/gshell/command/Command.java
> URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/geronimo/gshell/command/Command.java?rev=704975&r1=704974&r2=704975&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/
> geronimo/gshell/command/Command.java (original)
> +++ geronimo/gshell/trunk/gshell-api/src/main/java/org/apache/
> geronimo/gshell/command/Command.java Wed Oct 15 11:04:24 2008
> @@ -31,6 +31,8 @@
> {
> CommandLocation getLocation();
>
> + void setLocation(CommandLocation location);
> +
> /**
> * Returns the action of the command.
> *
>
> Modified: geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/
> main/java/org/apache/geronimo/gshell/wisdom/registry/
> CommandRegistryImpl.java
> URL: http://svn.apache.org/viewvc/geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/wisdom/registry/CommandRegistryImpl.java?rev=704975&r1=704974&r2=704975&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/
> java/org/apache/geronimo/gshell/wisdom/registry/
> CommandRegistryImpl.java (original)
> +++ geronimo/gshell/trunk/gshell-wisdom/gshell-wisdom-core/src/main/
> java/org/apache/geronimo/gshell/wisdom/registry/
> CommandRegistryImpl.java Wed Oct 15 11:04:24 2008
> @@ -60,9 +60,7 @@
> throw new DuplicateCommandException(name);
> }
>
> - if (command instanceof CommandSupport) {
> - ((CommandSupport)command).setLocation(new
> CommandLocationImpl(name));
> - }
> + command.setLocation(new CommandLocationImpl(name));
>
> commands.put(name, command);
>
>
>
|