geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <>
Subject Re: Improved EJB integration... can we get some portlets?
Date Wed, 08 Oct 2008 16:39:22 GMT

On Oct 8, 2008, at 7:42 AM, Manu George wrote:

> Hi David B,
>              All the attributes that you added in the container
> wrapper gbeans  are final. I understand the reason for them being
> final i.e. the attributes are used only during the creation of the
> container. Previously all the gbeans had a properties attribute and I
> used to add the configuration properties to that. I also think that it
> was not final. Currently without setters and with attributes being
> final I can no longer edit the gbean attributes. The way i see it we
> need to add setter methods and also make the attributes non final. Let
> me know what you think.
>     Previously the portlet would just edit the properties attributes
> of the gbean and inform the user that a server restart is necessary
> for the changes to be applied. What do you think is the approach i
> should take here?
> I observe that the admin console has a restart functionality which
> also starts all the dependencies so currently we will need only a
> restart of the openejb configuration

To me it looks like you are basically proposing a plan editor or  
config.xml editor for openejb.  You can't safely change the actual  
attribute values at runtime so lets look for a solution that doesn't  
pretend to be able to.

I think you have three possible strategies here:

1. create a plan editor for plans similar to the openejb plugin and  
use it to generate replacements for the openejb plugin
2. create an editor for specified customizations of config.xml.  This  
might or might not be practical.  It's more likely to work if the  
openejb plugin is stopped when you edit gbean attribute values.
3. put all the things you want to be able to change into config- 
substitutions as variables and edit those (in the in-memory map  
accessible through (????) ArtifactResolver).

david jencks
> Regards
> Manu
> On Fri, Oct 3, 2008 at 3:46 PM, Manu George  
> <> wrote:
>> Hi David,
>>       What is the accessTimeout attribute of the BmpContainerGBean
>> for? It seems to map to poolSize. You are doing a
>> set("AccessTimeout", Integer.toString(accessTimeout)); but there
>> doesn't seem to be such a property in EntityContainer.
>> Shouldn't this property be poolSize?
>> Regards
>> Manu
>> On Fri, Sep 26, 2008 at 6:14 PM, Manu George  
>> <> wrote:
>>> I will modify that patch to use the changes David has made. Let me
>>> know if you have any suggestions on the UI
>>> Regards
>>> Manu
>>> On 9/26/08, Donald Woods <> wrote:
>>>> I can try to check in the patch that's there, but I've never really
>>>> looked at or used EJBs and really don't have a burning desire to  
>>>> learn
>>>> it before we get 2.2 released.... :-)
>>>> I went ahead a assigned it back to Manu, since he's a committer  
>>>> now and
>>>> understands the OpenEJB side of things....
>>>> -Donald
>>>> David Blevins wrote:
>>>>> Wow, the screenshots on that issue look about perfect.  Is this
>>>>> something you'd want to hack on?
>>>>> -David
>>>>> On Sep 25, 2008, at 12:00 PM, Donald Woods wrote:
>>>>>> Maybe the code provided in
>>>>>> can be used 

>>>>>> as a
>>>>>> starting point?
>>>>>> -Donald
>>>>>> David Blevins wrote:
>>>>>>> So I improved the EJB integration so that there's a gbean for
>>>>>>> each
>>>>>>> container type and the exact attributes for each container are
>>>>>>> strongly typed gbean attributes.
>>>>>>> Is it possible we can get someone to create a portlet that  
>>>>>>> shows each
>>>>>>> ejb container in the system and allows people to edit the gbean
>>>>>>> attributes?
>>>>>>> Any volunteers?
>>>>>>> -David

View raw message