geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: [jira] Commented: (GERONIMO-4353) An uniform way to show error messages on the console
Date Fri, 17 Oct 2008 14:52:37 GMT
For #2, you're missing my point.  There should be no reason to modify 
the Dojo source to support this feature, as it would complicate our 
ability to upgrade to future Dojo 1.1.x or 1.2 releases without having 
to port this proposed change over and repackaging Dojo.

If you can't find a solution that doesn't require you to modify the Dojo 
released tar/zip bundle contents, then this feature should be canceled 
in my opinion.


-Donald


Ivan wrote:
> Thanks for the comments, Donald.
> 1. I am also working on improving the portlet usability by dojo, and it 
> will be dependent by all the console plugins, If this solution is 
> adopted :-)
> 2. Yes, it seems that I made a mistake about the placement of the 
> GMessages.js file.
>     For this js file is a dojo extension, which means it extends some js 
> class from dojo, so I guess it should be in the dojo's folder.
>     I am not familar with the assemblage mechanism, if putting it in one 
> of the console-*modules, can it be in the dojo plugin folder ? Or may I 
> package it to the dojo-min-1.1.1.zip in the repository folder ?
> 
> 
> 
> 2008/10/17 Donald Woods (JIRA) <jira@apache.org <mailto:jira@apache.org>>
> 
> 
>        [
>     https://issues.apache.org/jira/browse/GERONIMO-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640293#action_12640293
>     <https://issues.apache.org/jira/browse/GERONIMO-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640293#action_12640293>
>     ]
> 
>     Donald Woods commented on GERONIMO-4353:
>     ----------------------------------------
> 
>     -1 on the 20081014 patch.  The following file addition in the patch
>     concerns me -
>     dojo/geronimo-dojo/src/main/appended-resources/dijit/form/GMessages.js
> 
>     This dijit directory is created at build time by extracting the Dojo
>     1.1.1 files so they can be packaged.  We shouldn't be adding files
>     in the Dojo plugin...  Why is this not included in one of the
>     console-* modules instead?
> 
> 
>      > An uniform way to show error messages on the console
>      > ----------------------------------------------------
>      >
>      >                 Key: GERONIMO-4353
>      >                 URL:
>     https://issues.apache.org/jira/browse/GERONIMO-4353
>      >             Project: Geronimo
>      >          Issue Type: Improvement
>      >      Security Level: public(Regular issues)
>      >          Components: console
>      >    Affects Versions: 2.1.3
>      >            Reporter: Ivan
>      >         Attachments: Geronimo-4353.patch, snapshot.JPG
>      >
>      >
>      > Currently, different portlets uses different way to show those
>     error messages to the end user. We need a uniform way to do it.  The
>     simliar issue is opened in GERONIMO-2621, but it was closed due to
>     overwork on it in the past.
>      > I am trying to provide a solution, and will provide a demo in the
>     next few days. Thanks !
> 
>     --
>     This message is automatically generated by JIRA.
>     -
>     You can reply to this email to add a comment to the issue online.
> 
> 
> 
> 
> -- 
> Ivan

Mime
View raw message