geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: [jira] Commented: (GERONIMO-4353) An uniform way to show error messages on the console
Date Thu, 16 Oct 2008 19:56:42 GMT
Dojo should only get pulled into a server assembly if one of the 
installed pluginprofiles (or plugins) has a dependency on it.

BTW - the following file addition in the patch concerns me -
dojo/geronimo-dojo/src/main/appended-resources/dijit/form/GMessages.js

This dijit directory is created at build time by extracting the Dojo 
1.1.1 files so they can be packaged.  We shouldn't be adding files in 
the Dojo plugin...  Why is this not included in one of the console-* 
modules instead?


-Donald

Ivan wrote:
> Hi,
>      Yes, in the last discussion, for currently no component uses the 
> dojo (only plancreator uses the legacy dojo, I remember that it would 
> migrate to the new dojo version ?), so we temporary removed it from the 
> server.
>      But dojo is really a good tool to improve the usability of the 
> admin console, I guess we need it. And since a compact mini-dojo is 
> created, it currently only contains those must files.
>     
>      The reason that dojo is used here is also due to some technical 
> reason. For I want to display those messages on the portlets and wish it 
> does not impact the current existing portlets, so I print the messages 
> in a hidden html div tag and use dojo to load those messages. And so 
> that the developers of the portlets do not need to take care too much on 
> the message display, no extra work needs to done.
>     Thanks for any comment !
> 
> 2008/10/16 Lin Sun (JIRA) <jira@apache.org <mailto:jira@apache.org>>
> 
> 
>        [
>     https://issues.apache.org/jira/browse/GERONIMO-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640040#action_12640040
>     <https://issues.apache.org/jira/browse/GERONIMO-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640040#action_12640040>
>     ]
> 
>     Lin Sun commented on GERONIMO-4353:
>     -----------------------------------
> 
>     Hi, I'd like to understand why dojo is needed here since this is a
>     change to the base console.  I am under the impression that we want
>     to reduce server size  (from discussion on dev list, dojo seems to
>     have lots of files) and make some console components optional.
> 
>     Thanks Lin
> 
>      > An uniform way to show error messages on the console
>      > ----------------------------------------------------
>      >
>      >                 Key: GERONIMO-4353
>      >                 URL:
>     https://issues.apache.org/jira/browse/GERONIMO-4353
>      >             Project: Geronimo
>      >          Issue Type: Improvement
>      >      Security Level: public(Regular issues)
>      >          Components: console
>      >    Affects Versions: 2.1.3
>      >            Reporter: Ivan
>      >         Attachments: Geronimo-4353.patch, snapshot.JPG
>      >
>      >
>      > Currently, different portlets uses different way to show those
>     error messages to the end user. We need a uniform way to do it.  The
>     simliar issue is opened in GERONIMO-2621, but it was closed due to
>     overwork on it in the past.
>      > I am trying to provide a solution, and will provide a demo in the
>     next few days. Thanks !
> 
>     --
>     This message is automatically generated by JIRA.
>     -
>     You can reply to this email to add a comment to the issue online.
> 
> 
> 
> 
> -- 
> Ivan

Mime
View raw message