geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: svn commit: r702586 - in /geronimo/server/trunk/plugingroups/console-jetty: ./ pom.xml src/ src/main/ src/main/history/ src/main/history/dependencies.xml src/main/plan/
Date Wed, 08 Oct 2008 03:03:16 GMT
Why are we recreating the existing console-jetty and console-tomcat as 
yet another plugin?

Also, why are you including optional console plugins like 
activemq-console-xxx, which should only be included if the ActiveMQ 
plugins are installed?  By including it here, you're basically pulling 
in the JMS plugins.

I'm starting to reconsider why we need plugingroups, if we're going to 
have to recreate dozens of existing plugins just in a slightly different 
format just so we can include them in a special view just for custom 
server assemblies....



-Donald


linsun@apache.org wrote:
> Author: linsun
> Date: Tue Oct  7 12:09:59 2008
> New Revision: 702586
> 
> URL: http://svn.apache.org/viewvc?rev=702586&view=rev
> Log:
> Add the console-jetty plugin group
> 
> Added:
>     geronimo/server/trunk/plugingroups/console-jetty/
>     geronimo/server/trunk/plugingroups/console-jetty/pom.xml   (with props)
>     geronimo/server/trunk/plugingroups/console-jetty/src/
>     geronimo/server/trunk/plugingroups/console-jetty/src/main/
>     geronimo/server/trunk/plugingroups/console-jetty/src/main/history/
>     geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml
  (with props)
>     geronimo/server/trunk/plugingroups/console-jetty/src/main/plan/
> 
> Added: geronimo/server/trunk/plugingroups/console-jetty/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugingroups/console-jetty/pom.xml?rev=702586&view=auto
> ==============================================================================
> --- geronimo/server/trunk/plugingroups/console-jetty/pom.xml (added)
> +++ geronimo/server/trunk/plugingroups/console-jetty/pom.xml Tue Oct  7 12:09:59 2008
> @@ -0,0 +1,98 @@
> +<?xml version="1.0" encoding="ISO-8859-1"?>
> +<!--
> +    Licensed to the Apache Software Foundation (ASF) under one
> +    or more contributor license agreements.  See the NOTICE file
> +    distributed with this work for additional information
> +    regarding copyright ownership.  The ASF licenses this file
> +    to you under the Apache License, Version 2.0 (the
> +    "License"); you may not use this file except in compliance
> +    with the License.  You may obtain a copy of the License at
> +    
> +     http://www.apache.org/licenses/LICENSE-2.0
> +    
> +    Unless required by applicable law or agreed to in writing,
> +    software distributed under the License is distributed on an
> +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +    KIND, either express or implied.  See the License for the
> +    specific language governing permissions and limitations
> +    under the License.
> +-->
> +<!-- @version $Rev$ $Date$ -->
> +
> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
> +
> +    <modelVersion>4.0.0</modelVersion>
> +
> +    <parent>
> +        <groupId>org.apache.geronimo.plugingroups</groupId>
> +        <artifactId>plugingroups</artifactId>
> +        <version>2.2-SNAPSHOT</version>
> +    </parent>
> +
> +    <artifactId>console-jetty</artifactId>
> +    <packaging>car</packaging>
> +    <name>Geronimo Plugin Group :: Admin Console Jetty</name>
> +
> +    <description>
> +        This plugin group provides Admin Console Jetty functionality.
> +    </description>
> +
> +    <dependencies>
> +        <dependency>
> +            <groupId>org.apache.geronimo.configs</groupId>
> +            <artifactId>ca-helper-jetty</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>org.apache.geronimo.plugins</groupId>
> +            <artifactId>agent</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>org.apache.geronimo.plugins</groupId>
> +            <artifactId>mconsole-jetty</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>org.apache.geronimo.plugins</groupId>
> +            <artifactId>activemq-console-jetty</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>org.apache.geronimo.plugins</groupId>
> +            <artifactId>debugviews-console-jetty</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>org.apache.geronimo.plugins</groupId>
> +            <artifactId>plancreator-console-jetty</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>org.apache.geronimo.plugins</groupId>
> +            <artifactId>plugin-console-jetty</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +
> +        <dependency>
> +            <groupId>org.apache.geronimo.plugins</groupId>
> +            <artifactId>sysdb-console-jetty</artifactId>
> +            <version>${version}</version>
> +            <type>car</type>
> +        </dependency>
> +    </dependencies>
> +</project>
> +
> 
> Propchange: geronimo/server/trunk/plugingroups/console-jetty/pom.xml
> ------------------------------------------------------------------------------
>     svn:eol-style = native
> 
> Propchange: geronimo/server/trunk/plugingroups/console-jetty/pom.xml
> ------------------------------------------------------------------------------
>     svn:keywords = Date Revision
> 
> Propchange: geronimo/server/trunk/plugingroups/console-jetty/pom.xml
> ------------------------------------------------------------------------------
>     svn:mime-type = text/xml
> 
> Added: geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml?rev=702586&view=auto
> ==============================================================================
> --- geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml
(added)
> +++ geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml
Tue Oct  7 12:09:59 2008
> @@ -0,0 +1,49 @@
> +<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> +<plugin-artifact xmlns:ns2="http://geronimo.apache.org/xml/ns/attributes-1.2" xmlns="http://geronimo.apache.org/xml/ns/plugins-1.3">
> +    <module-id>
> +        <groupId>org.apache.geronimo.plugingroups</groupId>
> +        <artifactId>console-jetty</artifactId>
> +        <version>2.2-SNAPSHOT</version>
> +        <type>car</type>
> +    </module-id>
> +    <dependency>
> +        <groupId>org.apache.geronimo.plugins</groupId>
> +        <artifactId>plancreator-console-jetty</artifactId>
> +        <type>car</type>
> +    </dependency>
> +    <dependency>
> +        <groupId>org.apache.geronimo.plugins</groupId>
> +        <artifactId>sysdb-console-jetty</artifactId>
> +        <type>car</type>
> +    </dependency>
> +    <dependency>
> +        <groupId>org.apache.geronimo.plugins</groupId>
> +        <artifactId>activemq-console-jetty</artifactId>
> +        <type>car</type>
> +    </dependency>
> +    <dependency>
> +        <groupId>org.apache.geronimo.plugins</groupId>
> +        <artifactId>plugin-console-jetty</artifactId>
> +        <type>car</type>
> +    </dependency>
> +    <dependency>
> +        <groupId>org.apache.geronimo.configs</groupId>
> +        <artifactId>ca-helper-jetty</artifactId>
> +        <type>car</type>
> +    </dependency>
> +    <dependency>
> +        <groupId>org.apache.geronimo.plugins</groupId>
> +        <artifactId>debugviews-console-jetty</artifactId>
> +        <type>car</type>
> +    </dependency>
> +    <dependency>
> +        <groupId>org.apache.geronimo.plugins</groupId>
> +        <artifactId>mconsole-jetty</artifactId>
> +        <type>car</type>
> +    </dependency>
> +    <dependency>
> +        <groupId>org.apache.geronimo.plugins</groupId>
> +        <artifactId>agent</artifactId>
> +        <type>car</type>
> +    </dependency>
> +</plugin-artifact>
> 
> Propchange: geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml
> ------------------------------------------------------------------------------
>     svn:eol-style = native
> 
> Propchange: geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml
> ------------------------------------------------------------------------------
>     svn:keywords = Date Revision
> 
> Propchange: geronimo/server/trunk/plugingroups/console-jetty/src/main/history/dependencies.xml
> ------------------------------------------------------------------------------
>     svn:mime-type = text/xml
> 
> 
> 

Mime
View raw message