Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: domain of jgawor@gmail.com designates
 209.85.132.244 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=evl3y6yZS55ZZ+OExoW55LigHVveFmnyqM/VDpiWuX7YL/1ImxOevATB70CGXED5pX
         U9dUo0bPDR2TYW+fZHGfzwEYVyINBVGkhIamMkLDgynbR/od1g2E4INojKAT5FPhrlvi
         zyBWvI1UVskCsUlBz8k+9T74V8grr7WLKhR58=
Message-ID: <5eb405c70809201736l69dee8d3n1c22ca9bff639945@mail.gmail.com>
Date: Sat, 20 Sep 2008 20:36:19 -0400
From: "Jarek Gawor" <jgawor@gmail.com>
To: dev@geronimo.apache.org
Subject: Re: Lets use gshell for all startup stuff
In-Reply-To: <EBAD9D15-BD1F-450E-BD6D-0054C1F69FD8@yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <EBAD9D15-BD1F-450E-BD6D-0054C1F69FD8@yahoo.com>

Here are my thoughts on the switch to GShell:

-1 for geronimo.sh, and client.sh - the GShell alternatives start two
separate java processes: one for GShell env. and one for the server or
client container. That's unnecessary in most cases and slower.

-1 for shutdown.sh - it's nice and small. No need for the entire
GShell env. just to stop the server.

+1 for deployer.sh - but only if 1) support for offline deployment is
added, and 2) Windows paths are supported nicely (this might have been
fixed already)

+1 for jaxws-tools.sh - but but only if Windows paths are supported nicely.

In general, I would view GShell as another plugin to Geronimo so IMHO
it shouldn't be the main way to start/stop/deploy to Geronimo and it
shouldn't be part of the geronimo-boilerplate assembly. However, if we
are adding new functionality to Geronimo that needs CLI interface,
that should be written as a GShell command.

Also, things like Control-C on server started via start-server on
Windows should be fixed before switching. To be more useful for
Geronimo users, GShell should have better scripting capabilities
(conditionals, loops, etc.) and we should write more and/or more
interesting commands.

Jarek

On Thu, Sep 18, 2008 at 7:46 PM, David Jencks <david_jencks@yahoo.com> wrote:
> Lets change the scripts in bin that don't use gshell to use gshell.
>
> Then the helper scripts such as setjavaenv.sh will only be used for starting
> gshell and I hopefully they won't need most of their current contents.
>
> As noted in GERONIMO-4093 I'm not OK with requiring JAVA_HOME to be defined
> on systems that don't need it, and I took matters into my own hands and
> restored the old behavior of using "java" if JAVA_HOME is not defined.  I'm
> barely literate in bash so there may well be a better solution.
>
> thanks
> david jencks
>