geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Sun (JIRA)" <>
Subject [jira] Commented: (GERONIMO-4318) All the plugins are marked as installable on the install plugins portlet
Date Mon, 29 Sep 2008 15:01:44 GMT


Lin Sun commented on GERONIMO-4318:


I have tested the changes you made.  Looks good on the portlets.  There is a minor issue with
install .car file, when installing a .car file onto a server that already has the plugin,
as we don't notify the user that the plugin is already existed.  I am proposing the following
change to fix that, hopefully this would not interfere with your farming stuff.   let me know.

Index: framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/
--- framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/
(revision 699439)
+++ framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/
(working copy)
@@ -932,7 +932,7 @@
             // 2. Validate that we can install this
             if (!validatePlugin(data)) {
                 //already installed
-                return;
+                throw new MissingDependencyException("Already installed", toArtifact(data.getPluginArtifact().get(0).getModuleId()),

Also, I'd like to replace the MissingDependencyException to ConfigAlreadyExistException due
to this JIRA - GERONIMO-4230.  Any issue with that?


> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>                 Key: GERONIMO-4318
>                 URL:
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.2
> All the plugins are marked as installable on the install plugins portlet.   We check
if a plugin is installable by using pluginInstaller.validatePlugin.   If an exception is thrown,
then we set the installable to false.   The throw of MissingDependencyException in validatePlugin
method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails
because of the configuration is already installed.   This seems more reasonable and will also
get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install
a plugin that has already been installed using the "deploy install-plugin" command.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message