geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Gawor" <jga...@gmail.com>
Subject Re: svn commit: r699202 - in /geronimo/server/trunk: buildsupport/car-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/car/ framework/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/ framework/modules/
Date Fri, 26 Sep 2008 16:13:43 GMT
Hmm... how is the "installedArtifacts" updated when a plugin gets
uninstalled? Also, what should getInstalledPlugins() return? A list of
all plugins in the repo or a list of plugins enabled for the given
server instance?

Jarek

On Fri, Sep 26, 2008 at 10:55 AM, Lin Sun <linsun.unc@gmail.com> wrote:
> David, thanks for adding this to keep track of what plugins have been
> installed on the server.
>
> I think there is a prob with the change.  In InstallModulesMojo.java,
> as it set installedPluginsList as null.  I think this would cause all
> the plugins that came with the server assembly during build time
> (using c-m-p) not recorded, as saveHistory and loadHistory only handle
> cases when installedPluginList is not null.
>
> Also, in PluginInstallerGBean.java, I don't see anywhere you specify
> where we set the default location of the installedPluginsList file to
> "var/config/installedPlugins.properties"...  I only see that in the
> two test files.
>
> Lin
>

Mime
View raw message