geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "B.J. Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMODEVTOOLS-485) "About Eclipse Platform" testcase
Date Mon, 08 Sep 2008 14:08:44 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629169#action_12629169
] 

B.J. Reed commented on GERONIMODEVTOOLS-485:
--------------------------------------------

Thanks Ashish, this patch works for me, but I have several cosmetic issues.

1) EclipseUI.java has no copyright or @version $Rev$ $Date$ line
2) EclipseUI.java has 2 unused imports which show as warnings
3) EclipseUI.java and Abbot.java using tabs in stead of spaces
4) some other spacing issues that would make the code look nice (see below)
5) AbbotHelper.java rename clickButtonForToolItem to clickImageButton - it's a regular button
with an image on it that we are clicking, not a ToolItem like I originally thought it was.

For EclipseUI.java, it should probably look more like this...


public class EclipseUI extends WorkbenchTestCase {
    Shell aShell;
    AbbotHelper aHelper;

.......


           //aHelper.clickItem(newShell, "Geronimo v2.1 Server Adapter");*/
        }
        catch(Exception e) {
            e.printStackTrace();
        }
    }
}


> "About Eclipse Platform" testcase
> ---------------------------------
>
>                 Key: GERONIMODEVTOOLS-485
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-485
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>            Reporter: Tim McConnell
>            Assignee: Ashish Jain
>         Attachments: GERONIMODEVTOOLS-485.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message